Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify spec loading in docs with async and show loading errors #9207

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

domoritz
Copy link
Member

No description provided.

@domoritz domoritz requested a review from a team as a code owner December 14, 2023 21:17
@domoritz
Copy link
Member Author

Ignore the pending checks. We don't need them for this change.

Copy link
Member

@arvind arvind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One thought is whether we want to do any error checking for the fetch call? But, this question doesn't block the PR since I don't think we had any error checking for bad/404 URLs before either.

@domoritz
Copy link
Member Author

Added some error handling.

Screenshot 2024-01-22 at 11 33 22

@domoritz domoritz enabled auto-merge (squash) January 22, 2024 16:33
@domoritz domoritz changed the title refactor: simplify spec loading in docs with async refactor: simplify spec loading in docs with async and show loading errors Jan 22, 2024
@domoritz domoritz merged commit c33f46b into main Jan 22, 2024
11 checks passed
@domoritz domoritz deleted the dom/site-79324 branch January 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants