Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Tick and Bar Marks #933

Merged
merged 10 commits into from
Jan 13, 2016
Merged

Refactor Tick and Bar Marks #933

merged 10 commits into from
Jan 13, 2016

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jan 13, 2016

  • Use xc and yc for ticks so we don’t have to add offset
  • add offset for vertical dot plot with tick
  • config.mark.tickSize => config.mark.thickness
  • make size.value works with tick and bar mark – fixes Make size used by all mark types  #931

@kanitw kanitw changed the title [WIP] Refactor Tick and Marks [WIP] Refactor Tick and Bar Marks Jan 13, 2016
@kanitw kanitw changed the title [WIP] Refactor Tick and Bar Marks Refactor Tick and Bar Marks Jan 13, 2016
@kanitw kanitw mentioned this pull request Jan 13, 2016
Merged
domoritz added a commit that referenced this pull request Jan 13, 2016
@domoritz
Merge pull request #933 from vega/kw/tick
c279ae5 
Refactor Tick and Bar Marks
@domoritz domoritz merged commit c279ae5 into master Jan 13, 2016
@domoritz domoritz deleted the kw/tick branch January 13, 2016 18:55
domoritz added a commit that referenced this pull request Jan 13, 2016
@domoritz
Merge pull request #934 from vega/kw/refactor
fe9d084 
Follow up refactor for #933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@domoritz domoritz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make size used by all mark types
2 participants
@kanitw @domoritz