fix(#7724,#9414): Make ticks respect bin/timeUnit bands and custom band #9415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying vega-lite with
|
| Latest commit: |
c0a15b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1add4314.vega-lite.pages.dev |
| Branch Preview URL: | https://kw-tick-timebin.vega-lite.pages.dev |
ZacharyBys
approved these changes
Aug 28, 2024
kanitw
force-pushed
the
kw/tick-timebin
branch
2 times, most recently
from
9271390
to
5216a75
Compare
kanitw
force-pushed
the
kw/tick-timebin
branch
from
5216a75
to
c0a15b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Make ticks respect bin/timeUnit bands and custom band (by calling
rectPosition(), just like rect and bar marks)See the examples added as a proof for fixing.