Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: links in docs #9450

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix: links in docs #9450

merged 3 commits into from
Oct 8, 2024

Conversation

lukaw3d
Copy link
Contributor

@lukaw3d lukaw3d commented Oct 4, 2024 •
edited by domoritz
Loading

@lukaw3d
fix: broken link in the overview page
304fa16 
Fixes bc2f766
like c19bd8e.
@lukaw3d
fix: id collision of #interval chart and heading
646724b 
TOC tried to link to #interval heading, but showed chart.
@lukaw3d
fix: id collision of #point chart and heading
b71841c 
TOC tried to link to #point heading, but showed chart.
@lukaw3d lukaw3d requested a review from a team as a code owner October 4, 2024 02:13
domoritz
domoritz requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks like there are two unrelated changes in this pull request?

site/docs/parameter/select.md Show resolved Hide resolved
@domoritz domoritz enabled auto-merge (squash) October 4, 2024 17:31
@lukaw3d lukaw3d requested a review from domoritz October 7, 2024 22:14
@domoritz domoritz disabled auto-merge October 8, 2024 00:24
@domoritz domoritz merged commit 4098609 into vega:main Oct 8, 2024
10 checks passed
@lukaw3d lukaw3d deleted the fix-links branch October 10, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz Awaiting requested review from domoritz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaw3d @domoritz