first draft of fiveThirtyEight theme

[Casyfill]

Style inspired by Charts from fivethirtyeight

based on:

• charts 2014
• charts 2015
• charts 2016

[Casyfill]

is it something with formatting?

[domoritz]

Thank you so much for this PR. This is awesome.

Yes, just run yarn format and everything will be fine.

Can you add a screenshot of what it looks like now
?

[Casyfill]

Here is how it looks like right now - any suggestions are welcome;

https://beta.observablehq.com/@casyfill/538-theme-for-vega

[Casyfill]

going to fix

• label / ticks overlapping
• title

[domoritz]

Sweet! I'm excited and happy to merge this when you feel it's in a good state to be released. We can keep iterating over time.

Would you want to become a maintainer of Vega-Themes? I can add you so you can review PRs and issues for the 538 theme.

[domoritz]

Sorry for the strict formatting requirements. If you use the tslint and prettier extensions in your editor, things should format themselves automagically.

[Casyfill]

it seems it does not accept filled for symbols - also, for symbols in legend. shall we add this feature?

[domoritz]

it seems it does not accept filled for symbols - also, for symbols in legend. shall we add this feature?

In Vega?

[Casyfill]

@domoritz both symbol: filled and line: strokeCap via linter - see travis logs.

ah yes, maintenance-vise PRs would be nice; if you're ok, feel free to merge this - I won't probably have time to tweak minor details during next week or two. Thank you!

[Casyfill]

ah, one more thing - is that ok to name theme 538 or it might be a bad idea in terms of variable naming?

export { default as 538 } from './theme-fiveThirtyEight';

[domoritz]

Let's name it fivethirtyeight instead

[domoritz]

Also, can you check what you have done in #4 (comment)

[domoritz]

Are there more than 5 colors?

[Casyfill]

added 4 more + divergent and heatmap colormaps (see above)

[Casyfill]

added 4 more colors and heatmap + divergent colormaps

[Casyfill]

renamed as fivethirtyeight

[domoritz]

Looks great!

[Casyfill]

hm @domoritz can you explain that test fail, please?

[domoritz]

If you rebase against master, this issue should be fixed.

[domoritz]

Can you update the readme and make sure the example page works? I will merge then.

[Casyfill]

I think it is good to go - but I can't change your 'example' observable notebook - only fork from it; It's probably better if we change it on your side?

viewof theme = radio({
  title: 'Please select a theme',
  description: 'The charts below will update automatically.',
  options: [
    { label: 'Default', value: undefined },
    { label: 'Dark', value: 'dark' },
    { label: 'Microsoft Excel', value: 'excel' },
    { label: 'ggplot2', value: 'ggplot2' },
    { label: 'Quartz', value: 'quartz' },
    { label: 'Vox', value: 'vox' },
    { label: 'FiveThirtyEight', value: 'fivethirtyeight' }
  ],
  value: undefined
})

[domoritz]

Can you change test/index.html?

[domoritz]

Let's rename the file to fivethirtyeight.ts.

I also noticed that the stroke width of symbols is a little too small. Let's use at least 1.

[domoritz]

Fantastic. Thank you!

[Casyfill]

hoorah,
thanks for the help and guidance!

[domoritz]

It's now working on https://beta.observablehq.com/@domoritz/vega-themes-demo