Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate redundancy in method call #62

Closed
kanitw opened this issue Aug 23, 2016 · 2 comments
Closed

Eliminate redundancy in method call #62

kanitw opened this issue Aug 23, 2016 · 2 comments
Assignees
@light-and-salt
Milestone
2.0

Comments

@kanitw
Copy link
Member

kanitw commented Aug 23, 2016

Right now, there are way too many redundant parts in vl.tooltip and vg.tooltip
that's why you have call everything twice.

This is not a good practice for a few reasons:

  • Have to write the code twice for everything
  • If you do something wrong, then you have to correct twice.
  • It's entirely possible that you'll forget something in one of the place
  • Hard for code review.
@kanitw kanitw added this to the 2.0 milestone Feb 14, 2017
@kanitw
Copy link
Member Author

kanitw commented Feb 14, 2017

Not sure how much this issue is handled.

@sirahd
Copy link
Contributor

sirahd commented May 17, 2017

Fixed in #102

@sirahd sirahd closed this as completed May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@light-and-salt light-and-salt

Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@kanitw @light-and-salt @sirahd