Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Fix/locale formatting for volume #915

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Fix/locale formatting for volume #915

merged 4 commits into from
Oct 3, 2023

Conversation

mattrussell36
Copy link
Contributor

@mattrussell36 mattrussell36 commented Sep 28, 2023 •
edited
Loading

Needed for vegaprotocol/frontend-monorepo#4909

  • Removes hard-coded local setting which was resulting in formatting of the volume study to not pick up the users locale
  • Adds use of position decimal places to the default json data source for testing purposes

@MadalinaRaicu MadalinaRaicu merged commit 84414e3 into main Oct 3, 2023
1 check passed
@MadalinaRaicu MadalinaRaicu deleted the fix/locale-formatting-for-volume branch October 3, 2023 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwallacee bwallacee bwallacee approved these changes

@MadalinaRaicu MadalinaRaicu MadalinaRaicu approved these changes

@macqbat macqbat macqbat approved these changes

@johnwalley johnwalley Awaiting requested review from johnwalley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattrussell36 @macqbat @MadalinaRaicu @bwallacee