feat: remove market val proxy #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsiska-vega
approved these changes
Sep 26, 2023
witgaw
pushed a commit
that referenced
this pull request
Oct 12, 2023
gordsport
added a commit
that referenced
this pull request
Nov 1, 2023
* feat: Adding generic AC for perp order types (#1908) * feat: Adding generic AC for perp order types * refactor: clarify network parameter behaviour * feat: add acceptance criteria for program updates * feat: update features * fix spellcheck * fix: mkt param to be a netparam * refactor: update spelling as per feedback Co-authored-by: Tom <tom@vegaprotocol.io> * feat: add vesting spec * feat: add activity spec * feat: update reward distribution * feat: address vesting feedback * feat: update reward metrics * feat: add validator power metric * feat: add new entity scoping * refactor: linting and spellcheck fixes * refactor: address network param feedback * refactor: fix formatting * feat: update the validator ranking metric * fix: correct variable name * feat: add vested multiplier * feat: change total rewards calc as per feedback * feat: remove logarithmic functions * refactor: rename open-interest metric to position metric * fix: fix linting and spellcheck * feat: add validation for k * feat: address feedback Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: address exponential feedback Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: switch rank exponential distribution to table * feat: address feedback * feat: apply suggestion Co-authored-by: Barnaby M <b.mannerings@gmail.com> * feat: add limits * feat: clarify requirements not applied for certain metrics * feat: switch reward accounts to per unique transfer * refactor: clarification of lock period * feat: address comments * feat: address comments * feat: update json file * feat: remove 061062 * feat: typo * feat: formatting * feat: update format for formula * feat: Update AC 080 Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: update space * Update protocol/0042-LIQF-setting_fees_and_rewarding_lps.md Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: typo Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: typo Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: address comments * feat: benefit factors set by original referral set * feat: add reward multipliers for staking * refactor: rename maxBenefitTiers to maxReferralTiers * fix: update referral codes * refactor: address review comments * fix: correct equation for converting to quantum * feat: align with core implementation * feat: update market parameter part * feat: Adding perp margin calcs (#1915) * feat: Adding perp margin calcs * fixed: removed one ac * fix: ac numbers * fix: add quote * Update 0044-LIME-lp_mechanics.md (#1918) SLA remove 0044-LIME-010 * chore: Delete incorrect acceptance criteria relating to perps and market termination * chore: Update features.json to reflect removed ac * feat: update ACs in 0034 * feat: update AC code * fix: appprobation from pr#1921 * fix: features.json for PR 1921 (#1924) Updates the features.json as pt2 of #1921 . * Update 0044-LIME-lp_mechanics.md (#1925) * refactor: bring specs in line with implementation * refactor: remove undelegate in anger * refactor: add `0` account bit * refactor: general -> global * refactor: address comments from PR review * refactor: review suggestion Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * refactor: clarify details around `0` account * feat: update AC 0044-LIME-028 * Update protocol/0044-LIME-lp_mechanics.md Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * refactor: remove redundant sentences * Update protocol/0044-LIME-lp_mechanics.md Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * Update protocol/0044-LIME-lp_mechanics.md Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * addressed comments * chore: add two eth oracles ACs related to multiple contracts (#1926) * chore: add two eth oracles ACs related to multiple contracts * fix: Update protocol/0082-ETHD-ethereum-data-source.md --------- Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * modified for clarity and consistency * chore: tidy up the features.json file (#1929) * fix: reword ACs 38, 39 (#1923) Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * test: add a concrete example * fix: Spot ACs in features.json file (#1931) * fix: Spot ACs in features.json file moves the spot related SLA ACs into the spot feature for tracking * fix: dupes * feat: update AC 0044-LIME-026 * feat: update AC Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * fix: Minor spelling corrections, plus two new ACs for testing perp data is visible in REST and GRPC. * fix: logic fix * fix: align AC with implementation * Fix/fee calc step is netparam (#1937) * fix: fee distribution time step is a netparam * fix: fee distribution time step is a netparam * fix: fee distribution time step is a netparam * fix: fee distribution time step is a netparam --------- Co-authored-by: Paul Webb <86229849+vega-paul@users.noreply.github.com> * fix: revert the deployment name changes in the features.json file (#1943) * fix: align with core * fix: small correction * fix: Add tests for perpetuals doing protocol upgrade, checkpoint and network history. (#1940) Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * chore: add AC codes to referral ACs in fees spec (#1947) * chore: add AC codes to referral ACs in fees spec * chore: add Codes * refactor: move acs to correct section * feat: align acs with implementation * fix: remove legacy ac * chore: move batch transfers out of deployment 2 (#1948) * refactor: amend margin formula * feat: add clarification when no indicative price * fix/enacted doesn't mean leaves opening auction * fix: remove mentions of maturity * Update comsic from master (#1956) * refactor: floor slippage * User interface: add Post only and Reduce only (#1640) * draft for SORD * add AC for showing rejected reason * typo * execution flags on orders table * add codes to SORD * Update user-interface/7002-SORD-submit_orders.md Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> * add link to docs --------- Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> * Clarify rewards if multisig contains a key it should not (#1643) * Clarify rewards if multisig contains a key it should not * fix: MD lint error --------- Co-authored-by: gordsport <gordon@vegaprotocol.io> * feat: update FOK MO reduce-only * fix: Add some more cancel order ACs. * Update protocol/0033-OCAN-cancel_orders.md Co-authored-by: Tom <tom@vegaprotocol.io> * feat: Add a test for checking performance scores when checkpoint rest… (#1637) * feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch. * fix: Typo. * chore: Fix indentation (tabs/spaces). * feat: Add a test for checking performance scores when checkpoint rest… (#1637) * feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch. * fix: Typo. * chore: Fix indentation (tabs/spaces). * Update 0069-VCBS-validators_chosen_by_stake.md (#1653) Deleted half an AC as discussed on slack (as the number for the performance score didn't make sense here) * Amend price monitoring ACs (#1660) * refactor: update ACs * chore: tell approbation to leave me alone * chore: try again * refactor: rephrase AC * refactor: clarify * refactor: fix spelling * feat: update datanode spec with functionality to rollback node and functionality to fetch csv files containing network history (#1659) * feat: update datanode spec with functionality to rollback node and functionality to fetch csv files containing network history * fix: spell checker --------- Co-authored-by: gordsport <gordon@vegaprotocol.io> Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * spec: draft for time-based mempool pruning (#1645) * spec: draft for time-based mempool pruning Signed-off-by: Elias Van Ootegem <elias@vega.xyz> * spec: spelling Signed-off-by: Elias Van Ootegem <elias@vega.xyz> * Spelling + clarify how block height is determined Signed-off-by: Elias Van Ootegem <elias@vega.xyz> * spec: add some additional ACs, remove mention of TxV4, clarify that transaction data includes block hash in addition to block height Signed-off-by: Elias Van Ootegem <elias@vega.xyz> * complete acceptance criteria Signed-off-by: Elias Van Ootegem <elias@vega.xyz> * fix typo Signed-off-by: Elias Van Ootegem <elias@vega.xyz> --------- Signed-off-by: Elias Van Ootegem <elias@vega.xyz> Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * re-word ac * chore: Add decision notes template (#1658) * chore: Add decision notes template Added a decision template based loosely on the [Any Decision Records](https://adr.github.io/madr/) template Also updated some MD linting to allow sibling duplicated header titles and double spacing to make reading easier. * fix: Spelling error * feat: update for distributing remainder of liq fee * fix: correct AC * refactor: address feedback * add spec for current collateral * clarify total margin available * Update user-interface/7001-COLL-collateral.md Co-authored-by: Michael <michael@vega.xyz> * Update user-interface/7001-COLL-collateral.md Co-authored-by: Michael <michael@vega.xyz> * Update user-interface/7001-COLL-collateral.md Co-authored-by: Michael <michael@vega.xyz> * Update user-interface/7001-COLL-collateral.md Co-authored-by: Michael <michael@vega.xyz> * add asset file * Add ACs for asset detail dialog and link up with collateral spec * add suggested sort order per account type * fix: 005 AC code link (#1671) * fix: mempool pruning with PoW only * fix: linting errors * refactor: add liquidation price estimate * refactor: add ACs * refactor: another AC * refactor: cosmetic change * Update 0045-DSRC-data_sourcing.md (#1674) * Update 0045-DSRC-data_sourcing.md * Update 0045-DSRC-data_sourcing.md * Wording of timestamp AC --------- Co-authored-by: AnExsomnis <86832315+AnExsomnis@users.noreply.github.com> Co-authored-by: Barney Mannerings <b.mannerings@gmail.com> * add spec for current functionality fo fills data grid * Update user-interface/7005-FILL-fills.md Co-authored-by: Michael <michael@vega.xyz> * Update user-interface/7005-FILL-fills.md Co-authored-by: Michael <michael@vega.xyz> * Update user-interface/7005-FILL-fills.md Co-authored-by: Michael <michael@vega.xyz> * Make notional value of feels a could * Update user-interface/7005-FILL-fills.md Co-authored-by: Michael <michael@vega.xyz> * add clarification on user role for trades during continuos vs auction * fix: typo in ac number * feat: update typo in 0061 * feat: add explaination on ersatz validators * feat: correct typos * feat: typo * Update user-interface/7005-FILL-fills.md * add browser wallet spec as part of approbation set up * chore: fix typo and add browser specs to app.json * chore: add browser wallet to categories, hopefully in the right place * chore: Update 0033-OCAN-cancel_orders.md (#1686) * feat: update BRIE specs (#1654) * feat: update BRIE specs Signed-off-by: Jeremy Letang <me@jeremyletang.com> * chore: update spelling and linting * feat: update BRIE specs Signed-off-by: Jeremy Letang <me@jeremyletang.com> * chore: update spelling and linting * fix: spelling and lint and rebase * fix: spelling --------- Signed-off-by: Jeremy Letang <me@jeremyletang.com> Co-authored-by: gordsport <gordon@vegaprotocol.io> Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * chore: Update cosmic elevator branch from master (#1688) * refactor: let max oi drop during auciton * fix: duplicate AC codes in 0069-VCBS (#1536) (#1537) * Update `cosmicelevator` branch from `master` branch (#1550) * fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation * fix: duplicate AC codes in 0069-VCBS (#1536) * chore: trailing spaces * fix: remove the unused netparam; not liking that * chore: remove untestable AC from 0018 (#1530) * chore: reword 0063-VALK-013 * Update 0035-LIQM-liquidity_monitoring.md (#1539) * Update 0035-LIQM-liquidity_monitoring.md * Update 0035-LIQM-liquidity_monitoring.md * fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541) * Update 0011-NP-CLIE-client-interaction-tests.md * feat: allow any key to request multisg signers update bundle * feat: clarify spam status * refactor: let max oi drop during auciton * Wording tweaks for spam protection spec (#1548) * grammar etc fixes to spam protection * fix linting errors * chore: remove brackets * docs: another round of rewording * add related topics section Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> Co-authored-by: wwestgarth <william@vega.xyz> Co-authored-by: wwestgarth <westgarth.w@gmail.com> Co-authored-by: Paul Webb <86229849+vega-paul@users.noreply.github.com> Co-authored-by: RomanLeca <roman.leca@yahoo.com> Co-authored-by: Witold <witold@vega.xyz> Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> * Update cosmicelevator branch from master to keep up-to-date (#1560) * fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation * fix: duplicate AC codes in 0069-VCBS (#1536) * chore: trailing spaces * fix: remove the unused netparam; not liking that * chore: remove untestable AC from 0018 (#1530) * chore: reword 0063-VALK-013 * Update 0035-LIQM-liquidity_monitoring.md (#1539) * Update 0035-LIQM-liquidity_monitoring.md * Update 0035-LIQM-liquidity_monitoring.md * fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541) * Update 0011-NP-CLIE-client-interaction-tests.md * feat: allow any key to request multisg signers update bundle * feat: clarify spam status * refactor: let max oi drop during auciton * Wording tweaks for spam protection spec (#1548) * grammar etc fixes to spam protection * fix linting errors * chore: remove brackets * docs: another round of rewording * add related topics section * fix spelling in spam protection spec (#1553) * Update 0069-VCBS-validators_chosen_by_stake.md Added pending validator to VCBS-59 * Update 0069-VCBS-validators_chosen_by_stake.md Clarification on 0059 * Update 0062-SPAM-spam_protection.md * Update 0062-SPAM-spam_protection.md fixed link to defaults.go * Add quality checks to the makefile (#1556) * fix: broken links in the specs (#1557) * fix: remove broken kraken link --------- Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> Co-authored-by: wwestgarth <william@vega.xyz> Co-authored-by: wwestgarth <westgarth.w@gmail.com> Co-authored-by: Paul Webb <86229849+vega-paul@users.noreply.github.com> Co-authored-by: RomanLeca <roman.leca@yahoo.com> Co-authored-by: Witold <witold@vega.xyz> Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> Co-authored-by: Vegaklaus <62546834+Vegaklaus@users.noreply.github.com> * chore: Update cosmicelevator from master branch (#1564) * fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation * fix: duplicate AC codes in 0069-VCBS (#1536) * chore: trailing spaces * fix: remove the unused netparam; not liking that * chore: remove untestable AC from 0018 (#1530) * chore: reword 0063-VALK-013 * Update 0035-LIQM-liquidity_monitoring.md (#1539) * Update 0035-LIQM-liquidity_monitoring.md * Update 0035-LIQM-liquidity_monitoring.md * fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541) * Update 0011-NP-CLIE-client-interaction-tests.md * feat: allow any key to request multisg signers update bundle * feat: clarify spam status * refactor: let max oi drop during auciton * Wording tweaks for spam protection spec (#1548) * grammar etc fixes to spam protection * fix linting errors * chore: remove brackets * docs: another round of rewording * add related topics section * fix spelling in spam protection spec (#1553) * Update 0069-VCBS-validators_chosen_by_stake.md Added pending validator to VCBS-59 * Update 0069-VCBS-validators_chosen_by_stake.md Clarification on 0059 * Update 0062-SPAM-spam_protection.md * Update 0062-SPAM-spam_protection.md fixed link to defaults.go * Add quality checks to the makefile (#1556) * fix: broken links in the specs (#1557) * fix: remove broken kraken link * refactor: clarify 0042-LIQF-018 * feat: fix non-protocol linting and add makefile (#1563) * feat: fix non-protocol linting and add makefile * fix: remove binary file * fix: remove binary * fix: revert ui changes * fix: remove package files * Update glossaries/distributed-ledger-glossary.md --------- Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> Co-authored-by: wwestgarth <william@vega.xyz> Co-authored-by: wwestgarth <westgarth.w@gmail.com> Co-authored-by: Paul Webb <86229849+vega-paul@users.noreply.github.com> Co-authored-by: RomanLeca <roman.leca@yahoo.com> Co-authored-by: Witold <witold@vega.xyz> Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> Co-authored-by: Vegaklaus <62546834+Vegaklaus@users.noreply.github.com> * chore: Update cosmicelevator branch from master (#1573) * docs: post only orders (#1562) * docs: Adding specs for post-only orders * Update from master (#1602) * fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation * fix: duplicate AC codes in 0069-VCBS (#1536) * chore: trailing spaces * fix: remove the unused netparam; not liking that * chore: remove untestable AC from 0018 (#1530) * chore: reword 0063-VALK-013 * Update 0035-LIQM-liquidity_monitoring.md (#1539) * Update 0035-LIQM-liquidity_monitoring.md * Update 0035-LIQM-liquidity_monitoring.md * fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541) * Update 0011-NP-CLIE-client-interaction-tests.md * feat: allow any key to request multisg signers update bundle * feat: clarify spam status * refactor: let max oi drop during auciton * Wording tweaks for spam protection spec (#1548) * grammar etc fixes to spam protection * fix linting errors * chore: remove brackets * docs: another round of rewording * add related topics section * fix spelling in spam protection spec (#1553) * Update 0069-VCBS-validators_chosen_by_stake.md Added pending validator to VCBS-59 * Update 0069-VCBS-validators_chosen_by_stake.md Clarification on 0059 * Update 0062-SPAM-spam_protection.md * Update 0062-SPAM-spam_protection.md fixed link to defaults.go * Add quality checks to the makefile (#1556) * fix: broken links in the specs (#1557) * fix: remove broken kraken link * refactor: clarify 0042-LIQF-018 * feat: fix non-protocol linting and add makefile (#1563) * feat: fix non-protocol linting and add makefile * fix: remove binary file * fix: remove binary * fix: revert ui changes * fix: remove package files * Update glossaries/distributed-ledger-glossary.md * Update 0069-VCBS-validators_chosen_by_stake.md Added ACs to match the implementation so its codified (i.e., if an Ersatzvalidator drops below ownstake and there's no-one there to replace it, it is not demoted to pending. * Update 0069-VCBS-validators_chosen_by_stake.md * fix: Update acceptance criteria to correctly reflect implementation (#1549) Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * fix: update epoch ACs (#1555) Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * feat: update 0042, LP fee Transfer, Distribution * Add build folder to gitigore The approbation checks in `makefile` use this folder. Make sure it's not checked in. * Update protocol/0042-LIQF-setting_fees_and_rewarding_lps.md Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * Ignore dictionary Spellcheck creates a dictionary file. Ensure it isn't committed. * Un parallelise clone-sources in makefile The makefile tried to be clever and run all the remote-repo clones for Approbation checks in parallel. Due to my limited makefile skills, the check could run before a clone was finished. Run them in series instead. This also improves the output a little * Add specs param to names and codes in makefile The old behaviour (default paths) should have been deprecated ages ago, but hasn't been. This change makes it provide the same paths as the defaults. * feat: update maker fee transfer account * Update 0069-VCBS-validators_chosen_by_stake.md * Update protocol/0029-FEES-fees.md Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * Update protocol/0029-FEES-fees.md Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * Update protocol/0029-FEES-fees.md Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * Update 0048-DSRI-data_source_internal.md * fix: refactor 0069-VCBS-052 (#1570) Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> Co-authored-by: Vegaklaus <62546834+Vegaklaus@users.noreply.github.com> * fix: MD and spelling lint checks * fix: MD and spelling lint errors * fix: update wording for AC 0059-VCBS-016- (#1566) * Update 0062-SPAM-spam_protection.md (#1571) * Update 0062-SPAM-spam_protection.md * Update protocol/0062-SPAM-spam_protection.md * Update protocol/0062-SPAM-spam_protection.md --------- Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update 0011-NP-CLIE-client-interaction-tests.md (#1542) * Update 0011-NP-CLIE-client-interaction-tests.md Added ACs to test static spam protection (wallet doesn't allow you to get banned) * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update 0011-NP-CLIE-client-interaction-tests.md * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * Update 0011-NP-CLIE-client-interaction-tests.md * Update 0011-NP-CLIE-client-interaction-tests.md * chore: fix spelling and MD lint checks --------- Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> Co-authored-by: gordsport <gordon@vegaprotocol.io> * Update 0011-NP-CLIE-client-interaction-tests.md (#1579) * refactor: clarify AC * fix: adding bound on slippage part of margin * fix: adding bound on slippage part of margin - ACs * chore: lint * chore: format * chore: add ac codes * chore: lint * feat: make it nonlinear * fix: remove obsolete ac * fix: typo * fix: typo from comments Co-authored-by: Tom <tom@vegaprotocol.io> * fix: code block in list formatting (#1584) * chore: Remove untestable acceptance criteria * feat: add rate limit spec * Update 0057-TRAN-transfers.md (#1588) * Update 0057-TRAN-transfers.md * Update 0057-TRAN-transfers.md * chore: add AC codes * Update 0057-TRAN-transfers.md (#1590) * Update 0069-VCBS-validators_chosen_by_stake.md Added Acs for IssueSignature * Update 0069-VCBS-validators_chosen_by_stake.md * fix: Expand acceptance criteria to make them clear for 0011-NP-CLIE-client-interaction (#1585) * fix: Expand acceptance criteria to make them clear * chore: Fix formatting * fix: Address review comments --------- Co-authored-by: Paul Webb <86229849+vega-paul@users.noreply.github.com> * feat: Add new PLUP AC for state-sync in protocol upgrade. * feat: add closeout API * chore: tidy up * chore: remove blank line * chore: by more specific about when a client should be banned * feat: update formula line 140 * fix: Add extra cases for various things that might be affected by validators joining and leaving. * fix: Review comments for new ACs. * fix: Satisfy the linter. * refactor: add slippage to orders * refactor: update examples * chore: fix linter issues * refactor: fix typo * refactor: formlise margin level treatment * refactor: amend/add ACs * Update 0042-LIQF-setting_fees_and_rewarding_lps.md (#1598) * Update 0042-LIQF-setting_fees_and_rewarding_lps.md * fix: linting errors --------- Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> Co-authored-by: gordsport <gordon@vegaprotocol.io> * fix: linting error * fix: MD lint and spelling * Update 0069-VCBS-validators_chosen_by_stake.md (#1604) * Update 0069-VCBS-validators_chosen_by_stake.md * Update 0069-VCBS-validators_chosen_by_stake.md * Update 0069-VCBS-validators_chosen_by_stake.md * Update 0069-VCBS-validators_chosen_by_stake.md * Update 0069-VCBS-validators_chosen_by_stake.md * Update 0069-VCBS-validators_chosen_by_stake.md * Update 0069-VCBS-validators_chosen_by_stake.md * Update 0069-VCBS-validators_chosen_by_stake.md * Update 0069-VCBS-validators_chosen_by_stake.md * fix: MD linting and spelling errors --------- Co-authored-by: gordsport <gordon@vegaprotocol.io> * Update 0069-VCBS-validators_chosen_by_stake.md (#1596) * Update 0069-VCBS-validators_chosen_by_stake.md * fix: spelling errors --------- Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> Co-authored-by: gordsport <gordon@vegaprotocol.io> * fix: More validator join/leave test cases involving checkpoints. (#1601) * fix: More validator join/leave test cases involving checkpoints. * fix: spelling error * fix: Update AC codes to not be duplicates. --------- Co-authored-by: gordsport <gordon@vegaprotocol.io> Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * feat: update make file and add approabtion to CI (#1605) * feat: update make file and add approabtion to CI * chore: add more checks and fix errors * fix: checkout PR branch * fix: get branch * fix: approbation errors --------- Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> Co-authored-by: wwestgarth <william@vega.xyz> Co-authored-by: wwestgarth <westgarth.w@gmail.com> Co-authored-by: Paul Webb <86229849+vega-paul@users.noreply.github.com> Co-authored-by: RomanLeca <roman.leca@yahoo.com> Co-authored-by: Witold <witold@vega.xyz> Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> Co-authored-by: Vegaklaus <62546834+Vegaklaus@users.noreply.github.com> Co-authored-by: MuthuVega <91467655+MuthuVega@users.noreply.github.com> Co-authored-by: AnExsomnis <86832315+AnExsomnis@users.noreply.github.com> Co-authored-by: Jiajia-Cui <jiajia@vega.xyz> Co-authored-by: Edd <edd@vega.xyz> Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> Co-authored-by: claudiumilea <claudius.milea@gmail.com> Co-authored-by: Tom <tom@vegaprotocol.io> Co-authored-by: MuthuVega <muthu@vega.xyz> Co-authored-by: Philip Scott <phil@vega.xyz> Co-authored-by: Philip Scott <94362991+pscott31@users.noreply.github.com> Co-authored-by: Jake Bennett <jake@vegaprotocol.io> * fix: lint errors and duplicate paragraph (#1630) * fix: lint errors and duplicate paragraph * fix: MD lint error * Chore: Update cosmicelevator from master (#1646) * feat: Add new cases, mostly around eth changes during outages. A few extra cases for PUP. * chore: Linting fixes. * fix: More linting issues. * fix: spelling and AC code lint errors * fix: spelling * feat: Clarifying fees paid (or not paid) by post-only orders (#1635) * chore: remove invalid and unimplemented use cases * refactor: floor slippage * User interface: add Post only and Reduce only (#1640) * draft for SORD * add AC for showing rejected reason * typo * execution flags on orders table * add codes to SORD * Update user-interface/7002-SORD-submit_orders.md Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> * add link to docs --------- Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> * Clarify rewards if multisig contains a key it should not (#1643) * Clarify rewards if multisig contains a key it should not * fix: MD lint error --------- Co-authored-by: gordsport <gordon@vegaprotocol.io> --------- Co-authored-by: Jake Bennett <jake@vegaprotocol.io> Co-authored-by: Tom <tom@vegaprotocol.io> Co-authored-by: Rado <szpiechrados@gmail.com> Co-authored-by: Witold <witold@vega.xyz> Co-authored-by: Michael <michael@vega.xyz> Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> --------- Co-authored-by: Witold <witold@vega.xyz> Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> Co-authored-by: wwestgarth <william@vega.xyz> Co-authored-by: wwestgarth <westgarth.w@gmail.com> Co-authored-by: Paul Webb <86229849+vega-paul@users.noreply.github.com> Co-authored-by: RomanLeca <roman.leca@yahoo.com> Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> Co-authored-by: Vegaklaus <62546834+Vegaklaus@users.noreply.github.com> Co-authored-by: Tom <tom@vegaprotocol.io> Co-authored-by: MuthuVega <91467655+MuthuVega@users.noreply.github.com> Co-authored-by: AnExsomnis <86832315+AnExsomnis@users.noreply.github.com> Co-authored-by: Jiajia-Cui <jiajia@vega.xyz> Co-authored-by: Edd <edd@vega.xyz> Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> Co-authored-by: claudiumilea <claudius.milea@gmail.com> Co-authored-by: MuthuVega <muthu@vega.xyz> Co-authored-by: Philip Scott <phil@vega.xyz> Co-authored-by: Philip Scott <94362991+pscott31@users.noreply.github.com> Co-authored-by: Jake Bennett <jake@vegaprotocol.io> Co-authored-by: Rado <szpiechrados@gmail.com> Co-authored-by: Michael <michael@vega.xyz> * fix: fix prefix for browser wallet * chore: fixed wrong file.. * chore: now undo my formatting for the other file * chore: undo formatting change * add missing AC * add more ac * typoe * chore: add ac for the sprint * add ui specs for finding closed markets * fix number sequence * chore: add acs for market selector * chore: added ACs for transaction log * chore: removed navigation AC * add key pair ac that slipped the net via a ticket going straight to the done column * Add UI ACs for network and nodes (#1700) * Update 0002-WCON-connect_vega_wallet.md Removing all coulds, shoulds and would like tos. These are captured here and will be pulled into tickets as applicable later down the line if / when these features are implemented * Update user-interface/0002-WCON-connect_vega_wallet.md Co-authored-by: Penny Andrews <47143694+pennyandrews@users.noreply.github.com> * add settings ac * Update user-interface/1101-BWAL-browser_wallet.md * remove ac for recovery phrase and add new connection and transaction ac when not onboarded * add ac * add and increment * chore: update readme (#1709) Co-authored-by: peterbarrow <62435083+peterbarrow@users.noreply.github.com> * feat: typo * chore(trading): Add transfer ACs * chore(trading): Add transfer ACs number fix * chore: update proposal acs * fix(trading): Fix transfer specs ID * added all markets and proposal markets ACs * Fix: bring ersatz number in line with core. * increment and add ac * format * rework * chore: withdraw minimal amount * chore: add new market proposal acs * Update 1101-BWAL-browser_wallet.md Removed: - It is visually similar to other transaction types but essentially has less of the human readable detail(s) (design note) (1101-BWAL-057) as it is a design note - When I approve a transaction I can see confirmation that the transaction has been approved (1101-BWAL-045) - separate story in backlog - When I reject a transaction I can see confirmation that the transaction has been rejected (1101-BWAL-049) - separate story in backlog * chore:update todo * amend spec numbers * update acs * update numeration * 6501-ASSE-assets.md * add ac for import wallet * add list connections ac * update acs * A community settlement story. * fix: another AC for changing oracle after trading termination * fix: another AC for changing oracle after trading termination * chore: ACs added to 6002-MDET-market-details * chore: few more details added * Update user-interface/6002-MDET-market-details.md Co-authored-by: daro-maj <119658839+daro-maj@users.noreply.github.com> * chore: info about tooltips added * Update user-interface/6002-MDET-market-details.md Co-authored-by: Ben <ben@vega.xyz> * liquidity ACs * updated numeration * chore(trading): Add Position ACs (#1733) * chore(trading): Add Position ACs * chore: pr suggestion * remove outdated ac * update * chore: add AC for quantum formatting * chore: fix bold typo * chore: filled ACs in 6003-ORDB * disconnect ac * finger slip * test: market selector acs update * update console space * chore: remove cosmic feature from master (#1766) There has been some confusion when designing FE/UXs as the spec for governance transfers has changed slightly from whats in master. Its also the case that master should now be what is live in mainnet this feature is not one that is live. * chore: 6005-THIS-trade_history filled with ACs * popout windoiw * fix: clarify what's a market and what's a network param. * fix: clarify what's a market and what's a network param. * fix: clarify what's a market and what's a network param. * fix: typo Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * add browser wallet loading state ACs * chore: add AC for the button always being disabled (#1746) * Update 5002-LIQP-liquidity.md with 5002-LIQP-013 (#1769) * user-interface/ * depth chart ACs * update acs * update numbers * update name of reference * update * re-arrange browser wallet acs to save mainetenance (#1781) * re-arrange ac to save mainetenance * add file extension * onboarding spec tweak * final tweaks and removals * add specs to categories and apps --------- Co-authored-by: Dexter Edwards <dexter@vega.xyz> * chore(trading): 6004-CHAR-chart ACs created (#1775) * chore(trading): fix spec links * chore(trading): add code to apps.json * chore(trading): fix numbering * chore(trading): fix Char having duplicated id * chore(trading): fix id duplication * chore)trading): Fixing missed 0 * feat: use ghcr image to run approbation * feat: fix flags * fix: descriptions * chore(trading):add chart and orderbook ACs * add telemtry ac * update ac description * remove browser wallet * update README * Update 0036-BRIE-event_queue.md Added clarification on event forwarding * stop orders acs (#1859) * Update 6002-MDET-market-details.md Add some market successor specs * feat: fix some specs * Closed market list changes (#1828) * chore: remove spec on showing user pnl in closed market list * chore: add successor market acs * chore: update data display for mark price, liquidation price and pnl * `DATA`. Quantum decimals and accounts (#1512) * add more synonyms * introduce accounts * accounts are displayed as asset balances * introduce quantum * fix links to old DATA file * more detail * typo Co-authored-by: Edd <edd@vega.xyz> --------- Co-authored-by: Edd <edd@vega.xyz> * chore: add acs for network upgrade proposal (#1857) * chore: add acs for network upgrade proposal * chore: add acs for proposal enhancements * chore: proposal acs * chore: acs for successor market * Update the GitHub action token add_issue_new_projects.yml * chore: remove user-interface specs (#1877) * fix: add 048-COSMICELEVATOR-009 * fix: reword 0045-DSRC-012 * chore: update cosmic from matster * fix: missed conflict --------- Signed-off-by: Elias Van Ootegem <elias@vega.xyz> Signed-off-by: Jeremy Letang <me@jeremyletang.com> Co-authored-by: Witold <witold@vega.xyz> Co-authored-by: Michael <michael@vega.xyz> Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> Co-authored-by: Jiajia-Cui <jiajia@vega.xyz> Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> Co-authored-by: Jake Bennett <jake@vegaprotocol.io> Co-authored-by: Tom <tom@vegaprotocol.io> Co-authored-by: Vegaklaus <62546834+Vegaklaus@users.noreply.github.com> Co-authored-by: Matthew Pendrey <matthew.pendrey@gmail.com> Co-authored-by: Elias Van Ootegem <EVODelavega@users.noreply.github.com> Co-authored-by: Charlie <charles.ae.dummett@outlook.com> Co-authored-by: Charlie <99198652+cdummett@users.noreply.github.com> Co-authored-by: Matthew Russell <mattrussell36@gmail.com> Co-authored-by: Paul Webb <86229849+vega-paul@users.noreply.github.com> Co-authored-by: AnExsomnis <86832315+AnExsomnis@users.noreply.github.com> Co-authored-by: Barney Mannerings <b.mannerings@gmail.com> Co-authored-by: daro-maj <119658839+daro-maj@users.noreply.github.com> Co-authored-by: dalebennett1992 <dalebennett1992@hotmail.co.uk> Co-authored-by: dalebennett1992 <37066267+dalebennett1992@users.noreply.github.com> Co-authored-by: Jeremy Letang <me@jeremyletang.com> Co-authored-by: wwestgarth <william@vega.xyz> Co-authored-by: wwestgarth <westgarth.w@gmail.com> Co-authored-by: RomanLeca <roman.leca@yahoo.com> Co-authored-by: MuthuVega <91467655+MuthuVega@users.noreply.github.com> Co-authored-by: Edd <edd@vega.xyz> Co-authored-by: claudiumilea <claudius.milea@gmail.com> Co-authored-by: MuthuVega <muthu@vega.xyz> Co-authored-by: Philip Scott <phil@vega.xyz> Co-authored-by: Philip Scott <94362991+pscott31@users.noreply.github.com> Co-authored-by: Rado <szpiechrados@gmail.com> Co-authored-by: Penny Andrews <47143694+pennyandrews@users.noreply.github.com> Co-authored-by: Calum Pringle <46783148+ckpringle@users.noreply.github.com> Co-authored-by: peterbarrow <62435083+peterbarrow@users.noreply.github.com> Co-authored-by: Ben Wallace <ben@vega.xyz> Co-authored-by: Joe <joe@vega.xyz> Co-authored-by: m.ray <16125548+MadalinaRaicu@users.noreply.github.com> Co-authored-by: Dariusz Majcherczyk <dariusz.majcherczyk@gmail.com> Co-authored-by: Zohar Etzioni <zohar.etzioni@gmail.com> Co-authored-by: asiaznik <artur@vegaprotocol.io> Co-authored-by: Art <artur.siaznik@gmail.com> Co-authored-by: Dexter Edwards <dexter@vega.xyz> Co-authored-by: Joe Tsang <30622993+jtsang586@users.noreply.github.com> Co-authored-by: Sam Keen <samuel@vegaprotocol.io> Co-authored-by: Mikołaj Młodzikowski <mikolaj.mlodzikowski@gmail.com> Co-authored-by: Maciek <maciek@vegaprotocol.io> Co-authored-by: AnExsomnis <an9temetnosce@gmail.com> * fix: small correction * feat: add vesting acs * feat: add activity streak acs * feat: update features.json * feat: additional ACs * fix: correct approbation failures * refactor: improve wording with connectors * fix: align with core * fix: align with core * Update 0044-LIME-lp_mechanics.md (#1916) SLA 0044-LIME-006 Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * refactor: add funding payment * Fix example in 0083-RFPR-on_chain_referral_program.md From the same docs: > all `minimum_epochs` values must be an integer strictly greater than 0 * Update 0035-LIQM-liquidity_monitoring.md (#1964) * Update 0035-LIQM-liquidity_monitoring.md https://vegaprotocol.slack.com/archives/C9E6XA8GK/p1695151499045989?thread_ts=1695146384.224289&cid=C9E6XA8GK * fix: remove market.liquidity.targetstake.triggering.ratio * fix: linting * refactor: add perps AC * refactor: scale constant with volume * chore: add ac to feature * feat: add explanation on market life cycle * chore: align ACs with core implementation * feat: add additional referral ACs * feat: update features * fix: correct approbation * refactor: clarify 0083-RFPR-049 * fix: 0044-LIME-003 effect after epoch end (#1968) Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * fix: link (#1954) Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * chore: align closing_timestamp to end_of_program_timestamp * chore: update GOVE-140 to clarify reward account types update AC GOVE-140 to clarify reward account types and exclude metric based rewards from the referral feature * fix: update gov spec 141 (#1974) * chore: Update acceptance criteria to match implementation (#1967) * feat: Remove mention of market value proxy (#1975) * Update 0044-LIME-lp_mechanics.md (#1976) min value for market.liquidity.performanceHysteresisEpochs valid is 0 * chore: correct typos * chore: align protos with core implementation * feat: remove legacy ac * fix: update features * chore: add staking tiers * Update features.json to align milestone names (#1982) Updates features.json to align milestone names and report out correctly * chore: align spec with core implementation * feat: add AC to cover october reward features * fix: correct for markdownlint * refactor: correct AC behaviour * chore: correct typo * feat: add spam rules for referral program * chore: clarify all assets count towards deposit requirement * feat: add separate netparams for each transaction type * refactor: apply suggestion correcting typo Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * feat: add snapshot network parameter * feat: update spec with banning mechanics * chore: correct applyReferralCode typo * feat: clarify rejection and banning mechanisms * feat: remove non-vega restriction * chore: update 0070-MKTD-018 and 19 and add a new AC for exact precision (#1985) * chore: update 0070-MKTD-018 and 19 and add a new AC for exact presision * fix: dupe AC code * chore: make ACs 18 and 19 more valuable * fix: make wording more clear * Update protocol/0070-MKTD-market-decimal-places.md Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> --------- Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> * fix: remove specific time from the ACs (#1983) * fix: remove specific time from the ACs * fix: update * feat: add SLA edge case * feat: update format * chore: format * chore: remove empty space * Update 0062-SPAM-spam_protection.md (#1988) param names * feat: add entitiy scope acs * feat: update features.json * chore: clarify ac by removing weighted * Update 0028-GOVE-governance.md (#1992) * Update 0028-GOVE-governance.md auction termination AC changes 0028-GOVE-135 * Update 0028-GOVE-governance.md * Make referrals spec line up with implementation (#2009) * chore: spelling errors * feat: add validation for running volume values * chore: remove mention of program states * fix: correct validation * fix: corrrect ac code * fix: correct AC code to match implementation and tests --------- Co-authored-by: Charlie <charlie@vegaprotocol.io> Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * chore: align spec with implementation (#2002) Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * update gov-transfer max amount (#2014) * chore: align spec with implementation * chore: clarify acs to match existing tests * feat: add acs to cover multiple discount sources * fix: markdownlint failing * refactor: commit suggestion Co-authored-by: Valentin Trinqué <ValentinTrinque@users.noreply.github.com> * chore: removed descoped features from cosmic branch * chore: remove spot from cosmic approbation * chore: remove Batch change proposals from cosmic * chore: remove AC from wrong feature Its been put into spot for palazzo or later in chore: - #2004 --------- Signed-off-by: Elias Van Ootegem <elias@vega.xyz> Signed-off-by: Jeremy Letang <me@jeremyletang.com> Co-authored-by: Tom <tom@vegaprotocol.io> Co-authored-by: Charlie <charlie@vegaprotocol.io> Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> Co-authored-by: Sohill-Patel <85170301+Sohill-Patel@users.noreply.github.com> Co-authored-by: Charlie <99198652+cdummett@users.noreply.github.com> Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> Co-authored-by: Barnaby M <b.mannerings@gmail.com> Co-authored-by: Jiajia-Cui <jiajia@vega.xyz> Co-authored-by: Paul Webb <86229849+vega-paul@users.noreply.github.com> Co-authored-by: MuthuVega <muthu@vega.xyz> Co-authored-by: MuthuVega <91467655+MuthuVega@users.noreply.github.com> Co-authored-by: Witold <witold@vega.xyz> Co-authored-by: wwestgarth <westgarth.w@gmail.com> Co-authored-by: AnExsomnis <86832315+AnExsomnis@users.noreply.github.com> Co-authored-by: Jake Bennett <jake@vegaprotocol.io> Co-authored-by: Peter Barrow <pete@vega.xyz> Co-authored-by: Pete Barrow <62435083+peterbarrow@users.noreply.github.com> Co-authored-by: Karel Moravec <moravec.wdd@gmail.com> Co-authored-by: Michael <michael@vega.xyz> Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> Co-authored-by: Vegaklaus <62546834+Vegaklaus@users.noreply.github.com> Co-authored-by: Matthew Pendrey <matthew.pendrey@gmail.com> Co-authored-by: Elias Van Ootegem <EVODelavega@users.noreply.github.com> Co-authored-by: Charlie <charles.ae.dummett@outlook.com> Co-authored-by: Matthew Russell <mattrussell36@gmail.com> Co-authored-by: daro-maj <119658839+daro-maj@users.noreply.github.com> Co-authored-by: dalebennett1992 <dalebennett1992@hotmail.co.uk> Co-authored-by: dalebennett1992 <37066267+dalebennett1992@users.noreply.github.com> Co-authored-by: Jeremy Letang <me@jeremyletang.com> Co-authored-by: wwestgarth <william@vega.xyz> Co-authored-by: RomanLeca <roman.leca@yahoo.com> Co-authored-by: Edd <edd@vega.xyz> Co-authored-by: claudiumilea <claudius.milea@gmail.com> Co-authored-by: Philip Scott <phil@vega.xyz> Co-authored-by: Philip Scott <94362991+pscott31@users.noreply.github.com> Co-authored-by: Rado <szpiechrados@gmail.com> Co-authored-by: Penny Andrews <47143694+pennyandrews@users.noreply.github.com> Co-authored-by: Calum Pringle <46783148+ckpringle@users.noreply.github.com> Co-authored-by: Ben Wallace <ben@vega.xyz> Co-authored-by: Joe <joe@vega.xyz> Co-authored-by: m.ray <16125548+MadalinaRaicu@users.noreply.github.com> Co-authored-by: Dariusz Majcherczyk <dariusz.majcherczyk@gmail.com> Co-authored-by: Zohar Etzioni <zohar.etzioni@gmail.com> Co-authored-by: asiaznik <artur@vegaprotocol.io> Co-authored-by: Art <artur.siaznik@gmail.com> Co-authored-by: Dexter Edwards <dexter@vega.xyz> Co-authored-by: Joe Tsang <30622993+jtsang586@users.noreply.github.com> Co-authored-by: Sam Keen <samuel@vegaprotocol.io> Co-authored-by: Mikołaj Młodzikowski <mikolaj.mlodzikowski@gmail.com> Co-authored-by: Maciek <maciek@vegaprotocol.io> Co-authored-by: AnExsomnis <an9temetnosce@gmail.com> Co-authored-by: fryd <fryderyk@vega.xyz> Co-authored-by: Valentin Trinqué <ValentinTrinque@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.