-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: liquidity mechanisms overhaul #2299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
feat/0091-LIQM
branch
2 times, most recently
from
June 10, 2024 11:56
674e066
to
0f6c34e
Compare
witgaw
reviewed
Jun 19, 2024
witgaw
reviewed
Jun 19, 2024
cdummett
force-pushed
the
feat/0091-LIQM
branch
2 times, most recently
from
June 24, 2024 12:48
6388f2e
to
c531acb
Compare
Co-authored-by: Witold <witold@vega.xyz>
witgaw
previously approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cdummett
force-pushed
the
feat/0091-LIQM
branch
2 times, most recently
from
July 8, 2024 10:01
57ca59c
to
c5f61f1
Compare
witgaw
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2253
closes #2268
Warning
This PR will make the new liquidity reward metric #2266 redundant as the existing liquidity fees metric will no longer be abused from wash trading.
Instead #2309 should be merged, as this introduces an alternative method for the new liquidity reward metric where rewards are distributed pro-rata by the volume of notional each LP provides.
Summary
PR deprecates previous liquidity specs and replaces them with simplified liquidity mechanisms which:
In short the mechanics work as follows...
Open questions: