Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return stream error instead of context's #3069

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Return stream error instead of context's #3069

merged 1 commit into from
Mar 2, 2021

Conversation

qustavo
Copy link

@qustavo qustavo commented Mar 2, 2021

Closes #3063

ashleyvega
ashleyvega approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@ashleyvega ashleyvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qustavo qustavo merged commit 6d88291 into develop Mar 2, 2021
@qustavo qustavo deleted the bug/3063 branch March 2, 2021 10:12
jeremyletang pushed a commit that referenced this pull request Mar 3, 2021
@jeremyletang
Merge pull request #3069 from vegaprotocol/bug/3063
3f4abf7 
Return stream error instead of context's
@edd edd mentioned this pull request Mar 16, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyvega ashleyvega ashleyvega approved these changes

@jeremyletang jeremyletang jeremyletang approved these changes

@EVODelavega EVODelavega Awaiting requested review from EVODelavega

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic in tradingDataService.observe* functions
3 participants
@qustavo @jeremyletang @ashleyvega