update gql schema to use ID schalar + rename *ID -> *Id #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the String -> ID changes for IDs may be useful for the frontend, I've read somewhere that it was helping for graphql library to optimise caching related stuff... so it may be useful for you @edd @mattrussell36 |
ValentinTrinque
approved these changes
Mar 5, 2021
edd
approved these changes
Mar 5, 2021
jeremyletang
force-pushed
the
feature/3077-inconsistent-id-gql
branch
from
f0a4d2b
to
fdae27e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This do a tiny bit more than what 3077 expected which was to update ID/Id to be used consistently.
It also change all IDs kinds fields types from String to the ID scalar.
Let's maybe not merge this straight away as it may break the front-end?
close #3077