Cleaner and uniform market declaration in feature tests #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVODelavega
reviewed
Mar 8, 2021
EVODelavega
reviewed
Mar 8, 2021
EVODelavega
reviewed
Mar 8, 2021
ValentinTrinque
force-pushed
the
feature/3098-rework-market-declaration-feature-tests
branch
from
473783e
to
dab1e9c
Compare
We were using indexes to iterate through the table, which required to update all the indexes when adding or removing a column. To ease the maintenance of suche table, we introduce a generic layer to get the column by name, with appropriate type conversion. This makes us switch from the indexes to column name. To makes things even clearer, we add a specific layer on top of the generic one and abstract away column names into accessors. Doing so requires us to uniformize the column name across all tests, which is a good thing.
ValentinTrinque
force-pushed
the
feature/3098-rework-market-declaration-feature-tests
branch
from
dab1e9c
to
e4bf65c
Compare
ValentinTrinque
deleted the
feature/3098-rework-market-declaration-feature-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using indexes to iterate through the table, which required to update all the indexes when adding or removing a column.
To ease the maintenance of suche table, we introduce a generic layer to get the column by name, with appropriate type conversion.
This makes us switch from the indexes to column name.
To makes things even clearer, we add a specific layer on top of the generic one and abstract away column names into accessors.
Doing so requires us to uniformize the column name across all tests, which is a good thing.