Bugfix/3086 closed out lp cannot re submit #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyletang
force-pushed
the
bugfix/3086-closed-out-lp-cannot-re-submit
branch
from
4782b07
to
e32c54e
Compare
EVODelavega
approved these changes
Mar 9, 2021
jeremyletang
force-pushed
the
bugfix/3086-closed-out-lp-cannot-re-submit
branch
from
e32c54e
to
3146e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implemented @3jtechtest test exactly, could not find the issue.
Found a smaller one where we were trying to update liquidity of the same orders in loop, fixed it. And replaced the amend by a cancel as we always cancel basically.
close #3086