Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not return an error if CancelAllOrders returns ErrTradingNotAllowed #3140

Merged
merged 1 commit into from
Mar 10, 2021
Merged

do not return an error if CancelAllOrders returns ErrTradingNotAllowed #3140

merged 1 commit into from
Mar 10, 2021

Conversation

jeremyletang
Copy link
Member

close #3139

ponthief
ponthief approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@ponthief ponthief left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on the fix branch - passed

@ponthief ponthief merged commit 47cc8ff into develop Mar 10, 2021
@edd edd mentioned this pull request Mar 16, 2021
Closed
3 tasks
@ValentinTrinque ValentinTrinque deleted the bugfix/3139 branch June 14, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponthief ponthief ponthief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancellation - Unable to cancel orders for the party on the multiple markets
2 participants
@jeremyletang @ponthief