Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed debug code (#3283) #3284

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Removed debug code (#3283) #3284

merged 3 commits into from
Mar 30, 2021

Conversation

peterbarrow
Copy link
Contributor

Removed some debug code that was setting the log level to DEBUG no matter what the config said.

@jeremyletang
Copy link
Member

@peterbarrow could we use the level from the config to be setup there?

jeremyletang
jeremyletang approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@jeremyletang jeremyletang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once all tests are passing.

@peterbarrow peterbarrow merged commit 4a25646 into develop Mar 30, 2021
@peterbarrow peterbarrow deleted the 3283-remove-debug-log-level-setting branch March 30, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyletang jeremyletang jeremyletang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbarrow @jeremyletang