Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up th governance engine unit tests #3295

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

ValentinTrinque
Copy link
Contributor

@ValentinTrinque ValentinTrinque commented Apr 1, 2021

Result on code coverage from code refactoring

file coverage before coverage after
asset.go 0% statements 0% statements
config.go 100% statements 100% statements
engine.go 42.3% statements 79.7% statements
market.go 65.7% statements 65.7% statements
netparams.go 60.9% statements 60.9% statements
node_validation.go 5.3% statements 11.8% statements
proposal.go 22.7% statements 36.4% statements
service.go 0% statements 0% statements

Close #2011

@ValentinTrinque ValentinTrinque self-assigned this Apr 1, 2021
@ValentinTrinque ValentinTrinque changed the title Voting API should fails when voting with 0 token Voting API should fail when voting with 0 token Apr 1, 2021
@ValentinTrinque ValentinTrinque force-pushed the feature/2011-voting-api-should-fail branch 2 times, most recently from 997c3ea to 0c84d33 Compare April 1, 2021 14:05
@ValentinTrinque ValentinTrinque force-pushed the feature/2011-voting-api-should-fail branch from 0c84d33 to 920f346 Compare April 1, 2021 14:23
@ValentinTrinque ValentinTrinque marked this pull request as ready for review April 1, 2021 14:52
@ValentinTrinque ValentinTrinque changed the title Voting API should fail when voting with 0 token Clean up th governance engine unit tests Apr 1, 2021
@edd edd requested a review from peterbarrow April 1, 2021 15:32
@ValentinTrinque ValentinTrinque merged commit 307600d into develop Apr 2, 2021
@edd edd mentioned this pull request Apr 7, 2021
@edd edd mentioned this pull request Apr 15, 2021
@ValentinTrinque ValentinTrinque deleted the feature/2011-voting-api-should-fail branch June 14, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voting API should tell you if you don't have enought VOTE tokens
2 participants