Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Factorio 1.1 #17

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Updated to Factorio 1.1 #17

merged 3 commits into from
Jan 5, 2021

Conversation

jeison-souza
Copy link
Contributor

Hi, I just wrote a quickfix to allow this mod to run on 1.1.

Thanks for the mod btw.

@jeison-souza
Copy link
Contributor Author

I saw that it seems that another test project of yours is missing some files.

As I just touched a not tested UI format, all tests should work well as before. I hope these modifs can help you to fix this mod to 1.1

I'm gaming with this modified version and had no errors until now.

Thanks

@veger
Copy link
Owner

veger commented Dec 29, 2020

Thank you for your contribution.
I'll try to find time to fix the error, it is due to a wrong branch (my PR got accepted and I removed my fork... 😞 )

After that we can merge this PR

scripts/gui.lua Show resolved Hide resolved
@veger
Copy link
Owner

veger commented Jan 3, 2021

Sorry I was a little late(r) with my response, but the holidays and kids messed up my plans... 😉
I found a small issue when trying the mod on 1.1, if you can fix it, I'll merge the PR and make a release

@veger
Copy link
Owner

veger commented Jan 3, 2021

PS If you (also) merge the updated master branch from my repo the tests should work again

@veger veger merged commit f1c22ae into veger:master Jan 5, 2021
@jeison-souza
Copy link
Contributor Author

jeison-souza commented Jan 7, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants