Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make behavior of unknown tags configurable #36

Merged
merged 2 commits into from
May 27, 2019
Merged

Conversation

veger
Copy link
Owner

@veger veger commented May 26, 2019

Unknown tags are treated as text, unless configuration is used to instead raise an exception.

Fixes #33

@coveralls
Copy link

coveralls commented May 26, 2019

Coverage Status

Coverage increased (+0.01%) to 99.862% when pulling dff2b48 on ignore-unknown-tags into f96cb1c on master.

@almaron
Copy link

almaron commented May 27, 2019

A much neater solution. But I'd rather have an option to completely ignore those tags (i.e. not render anything) or treat them as text.

@almaron
Copy link

almaron commented May 27, 2019

So maybe we can set the configuration to be slightly more flexible.
Like have :exception, :text, :ignore possibilities.

@veger
Copy link
Owner Author

veger commented May 27, 2019

you mean you want to hide the tags themselves and only show text in between?
Could be a neat option yes, let me see if we can change the code and grab this from existing tag_info

@veger veger changed the title Optionally raise exception if unknown tag is encountered Make behavior of unknown tags configurable May 27, 2019
@veger veger merged commit 87c44cc into master May 27, 2019
@veger veger deleted the ignore-unknown-tags branch May 27, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore unknown/wrong tags
3 participants