Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Regex to find arbitrary number of links #28

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

DorianLoeben
Copy link
Contributor

This adds a new option suggested by #25
It dynamically creates the regex with the suggested shortening of the regex if one of the values is 0.
From my very limited testing this seems to work, however it very quickly creates lines that are >50 Characters.

New Layout

I'm not a Webdev, so this needs some fixing on the css side of things.
Also please let me know if on the react side of thing there are things to improve

This does not implement the 3 or 4 Link Regex changes that were suggested.

@veiset
Copy link
Owner

veiset commented Aug 18, 2022

Great work, the code looks good. I think the way it is presented takes a little too much space.

Are you able to structure it this way:
image

(check out the function SocketCheckbox for css inspiration 😁, you probably want to expose imgFromChar to easily get the image)

The input box probably needs to show placeholder="0" as a default number to avoid looking like checkboxes.

@DorianLoeben
Copy link
Contributor Author

Thanks for the suggestions, I'll look into how I can position it like that.
I'll add the placeholder.

@veiset
Copy link
Owner

veiset commented Aug 18, 2022

I'm heading to work, but I will look at this in around 8 hours.

I'll do some testing and if everything looks good I'll merge and publish it.

@DorianLoeben
Copy link
Contributor Author

Changed the things. Had a fight with css. If needed I would refactor it if you want, but then it would probably take longer than League start :)

@veiset
Copy link
Owner

veiset commented Aug 18, 2022

This looks very good. Thanks for taking the time to implement it!

I'll merge it in a few hours and we can always refactor after league start! 😁

@veiset
Copy link
Owner

veiset commented Aug 18, 2022

I did a few small adujstments to the page, check out the commit: 4f1d0ec

Sorry about the delay of publishing the page but github has had some issues with github-actions for the last few hours. I'll publish it as soon as I'm able to.

Edit: Its live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants