Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings after upgrade to HA 2025.1.0 #96

Open
niekniek89 opened this issue Jan 4, 2024 · 32 comments
Open

Warnings after upgrade to HA 2025.1.0 #96

niekniek89 opened this issue Jan 4, 2024 · 32 comments

Comments

@niekniek89
Copy link

After upgrading to the latest HA Release, i see a lot of warnings:

image
image
image
image

@niekniek89 niekniek89 changed the title Warnings after upgrade to HA 2024.0.1 Warnings after upgrade to HA 2024.1.0 Jan 4, 2024
@ghostsam45
Copy link

same issue but no emergency before 2025.1, just that it pollutes the logs

@DeFlanko
Copy link

I think i see the warnings:

2024-02-14 11:27:23.640 WARNING (MainThread) [homeassistant.helpers.entity] Entity media_player.samsung_un55mu6300_guy_lan (<class 'custom_components.samsungtv_tizen.media_player.SamsungTVDevice'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <MediaPlayerEntityFeature.PAUSE|VOLUME_SET|VOLUME_MUTE|PREVIOUS_TRACK|NEXT_TRACK|TURN_ON|TURN_OFF|PLAY_MEDIA|VOLUME_STEP|SELECT_SOURCE|PLAY: 20413>, please report it to the author of the 'samsungtv_tizen' custom integration and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation
2024-02-14 11:27:23.641 WARNING (MainThread) [homeassistant.helpers.entity] Entity media_player.samsung_un55nu6900_elly_lan (<class 'custom_components.samsungtv_tizen.media_player.SamsungTVDevice'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <MediaPlayerEntityFeature.PAUSE|VOLUME_SET|VOLUME_MUTE|PREVIOUS_TRACK|NEXT_TRACK|TURN_ON|TURN_OFF|PLAY_MEDIA|VOLUME_STEP|SELECT_SOURCE|PLAY: 20413>, please report it to the author of the 'samsungtv_tizen' custom integration and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation
2024-02-14 11:27:23.641 WARNING (MainThread) [homeassistant.helpers.entity] Entity media_player.samsung_qn82q6fna_lr_lan (<class 'custom_components.samsungtv_tizen.media_player.SamsungTVDevice'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <MediaPlayerEntityFeature.PAUSE|VOLUME_SET|VOLUME_MUTE|PREVIOUS_TRACK|NEXT_TRACK|TURN_ON|TURN_OFF|PLAY_MEDIA|VOLUME_STEP|SELECT_SOURCE|PLAY: 20413>, please report it to the author of the 'samsungtv_tizen' custom integration and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

@6of6
Copy link

6of6 commented Mar 16, 2024

I'm a newbie, but the README says, "This current integration is not maintainable..." and then goes on to say, "I have no need for this..." and, "I would be asking money for it..."

Am I missing something?

@veista
Copy link
Owner

veista commented Mar 16, 2024

Hi,

There are a lot of devices that are not supported by this integration. It is too much work to add support for every device individually and make sure it does not break others. Also keeping up with the official integration.

This integration has everything I need for my personal devices. To be able to maintain other devices I would need to make a better integration for this purpose.

I will fix these issues when they break the integration for me untill I get the new integration up and running.

@DeFlanko
Copy link

DeFlanko commented Mar 16, 2024 via email

@brinkgit
Copy link

brinkgit commented Apr 1, 2024

...... untill I get the new integration up and running

I hope that does mean that also in the future an integration will be there to manage the windfree airco's?

Otherwise I have to try something else.
So far I managed some control actions for the AC via voicecontrol (google). But I cannot find a complete list of commands for voicecontrol. Anyone did?

@cgraf
Copy link

cgraf commented Aug 5, 2024

I've fixed this to the point where there are no more deprecation warnings, but before releasing another fork that will probably not get merged, I'm wondering if someone could verify that the functionality that makes them want to use this integration is still not present in the official core integration. It looks like that one is being updated now.

@niekniek89
Copy link
Author

@cgraf
I still have a few things that don't work:

Icemaker switch
cooling temperature sensor/number
freezer temperature sensor/number

I can't solve that with other integrations either.
It worked for a few months.

@cgraf
Copy link

cgraf commented Aug 5, 2024

Yeah, I don't think the fixing the future deprecation warnings is going to fix you ice maker and temps, but I will try to get it up in the next couple of days, just to remove some log pollution.

I'm surprised your sensors previously worked, and no longer work, without error.

A while back I added support for my own refrigerator, but that was as simple as including a model number somewhere I think.

It is definitely difficult to maintain something like this, which supports a whole bunch of devices that a single author is not going to have. These aren't just $10 devices that you can buy for testing and be able to use. It really needs a maintainer for each device, or at least every major type of device, or it would be great if Samsung produced an emulator which mimics the signals from the devices.

@niekniek89 what is the model number of your refrigerator? Not sure if you've checked them out but there are a couple of old PRs waiting for merge that add specific model support. https://github.com/veista/smartthings/pulls

@cgraf
Copy link

cgraf commented Aug 5, 2024

Just pushed the log cruft cleanup to my old existing branch.

1ac2c32

@niekniek89
Copy link
Author

niekniek89 commented Aug 5, 2024

Yeah, I don't think the fixing the future deprecation warnings is going to fix you ice maker and temps, but I will try to get it up in the next couple of days, just to remove some log pollution.

I'm surprised your sensors previously worked, and no longer work, without error.

A while back I added support for my own refrigerator, but that was as simple as including a model number somewhere I think.

It is definitely difficult to maintain something like this, which supports a whole bunch of devices that a single author is not going to have. These aren't just $10 devices that you can buy for testing and be able to use. It really needs a maintainer for each device, or at least every major type of device, or it would be great if Samsung produced an emulator which mimics the signals from the devices.

@niekniek89 what is the model number of your refrigerator? Not sure if you've checked them out but there are a couple of old PRs waiting for merge that add specific model support. https://github.com/veista/smartthings/pulls

Thanks for your help so far.
The smartthings HACS integration in HA says:

TP1X_REF_21K

Samsung website (link)
How can I update the integration later?

@cgraf
Copy link

cgraf commented Aug 5, 2024

Ha! If that is actually your model, that is my model too, so I might be able to actually help you, however, the Samsung link you gave does not look like my model. I don't know much about SmartThings or Samsung model naming at all. It could be that TP1X_REF_21K is just a group of feature sets, rather than specific model.

Grab the files from 1ac2c32 and overwrite the ones in your conf/custom_components/smartthings/ directory. Then restart home assistant (not quick restart).

At the very least, your deprecation warnings go away, and at best maybe it fixes your actual issues. It shouldn't break anything or make anything worse for you.

When this version is officially updated, it will overwrite these custom files automatically. You can also force an overwrite of my changes by going to HACS->Integrations->SmartThingsCustom->(click three dots in upper right and select "redownload").

@cgraf
Copy link

cgraf commented Aug 5, 2024

If you have a look at the issue from nearly a year ago, you can see what my changes do for TP1X_REF_21K.

#81

I updated that branch today with the fixes for the deprecation warnings, so it has both sets of changes.

@niekniek89 niekniek89 changed the title Warnings after upgrade to HA 2024.1.0 Warnings after upgrade to HA 2025.1.0 Aug 5, 2024
@niekniek89
Copy link
Author

Thanks for you’re help for now.
I’ll will check it later today👌🏻.

@niekniek89
Copy link
Author

@cgraf
Hi,

I just downloaded all 18 separate files, and placed them in conf/custom_components/smartthings/

After rebooting HA, I indeed no longer get any error messages!
Only 2 extra sensors disappear again;
fast cooling
fast freezing

So I put the 18 separate files back.

@cgraf
Copy link

cgraf commented Aug 6, 2024

Heh. I actually had to look in my manual to see if I have those features. I apparently do, so I added support to TP1X_REF_21K. Grab the branch again and you should see them now.

@niekniek89
Copy link
Author

Thanks @cgraf

the files were last modified 20 hours ago.
i think i can't download/try anything new.

@cgraf
Copy link

cgraf commented Aug 6, 2024

The only file that changed this time was switch.py. If you still have your previous download, just grab switch.py. https://github.com/veista/smartthings/pull/83/files

Incidentally I did test the enablement of power freeze, power cool and ice maker using the SmartThings iPhone app. My fridge has two ice types (cubes and bites). The switch only controls cubes. I may see at some point if I can add the switches for ice bites, and for water pitcher fill features, which are present in my fridge.

@niekniek89
Copy link
Author

Hi,

I just downloaded the switch.py ​​file, replaced it, and restarted HA.
Unfortunately without any results.

image
image

@cgraf
Copy link

cgraf commented Aug 6, 2024

Maybe I don't know what you are talking about. The "Power Cool" and "Power Freeze" switches may not have been present before? Not sure why icemaker is not showing. It is all in the same logic.

@cgraf
Copy link

cgraf commented Aug 6, 2024

image

@niekniek89
Copy link
Author

hi,

The "Power Cool" and "Power Freeze" switches were always visible. the temp sensors have also not been working for a long time, same as the icemaker switch.

@niekniek89
Copy link
Author

strange that it doesn't work for me yet...

@cgraf
Copy link

cgraf commented Aug 6, 2024

Ok. Maybe I misunderstood you comments

Only 2 extra sensors disappear again;
fast cooling
fast freezing

Are you sure you don't have anything under "entities not shown"?

@cgraf
Copy link

cgraf commented Aug 6, 2024

FWIW, before doing a lot of work on this custom branch of a customization of a core app, I decided to try the core app again since I see it is being updated. The functionality of the core app for my refrigerator is exactly the same as my branch here and the cooler setpoint slider actually works. The freezer slider still does not, but it has ice maker, power freeze and power cool switches which all work. I may just stick with that one for a while rather than doing a lot of work here.

@veista
Copy link
Owner

veista commented Aug 7, 2024

Smartthings api provides most functionality if implemented. Seems like now it is to the "official" integration, which is great. There are only minor things that are only in OCF, like climate display on/off functions. My idea is to make an itegration that provides "only" these missing functions and would be used with the "official" core integration. There is no point adding basic functions here, since after the transition this integration will be discarded.

@niekniek89
Copy link
Author

Thanks.

I just removed the HACS integration "Smartthings", restarted HA, installed HACS, restarted HA and reconfigured it (with the modified files), but unfortunately not all sensors are seen (which has always worked before).

Anyone?

@cgraf
Copy link

cgraf commented Aug 8, 2024

If you've installed the core version, you might try creating an issue there. There is no officially assigned maintainer, but it does look like it has an active community who may be able to help.

@niekniek89
Copy link
Author

@cgraf

I installed the smartthings integration within HACS, and not the default HA integration.

@cgraf
Copy link

cgraf commented Aug 8, 2024

You have three choices:

  1. Install the current default HACS version which has had three lines of code changed in the last two years.
  2. Install my fork which has some minor model support updates and removes the deprecation warnings.
  3. Install the core version which has received some updates in the last few weeks and does not require HACS.

I'm on option 3 right now, and it is better than my fork.

@niekniek89
Copy link
Author

niekniek89 commented Aug 8, 2024

I have now installed the core version, and now have even less:

image

I seem to have this model:
TP1-22-REV1_20240204

@6of6
Copy link

6of6 commented Sep 13, 2024

I have one Samsung/Smarthings device; a heat pump. I recently "changed" to the the core integration and changed back because I lost (or couldn't find).

  1. Energy data
  2. Filter data
  3. Light data
  4. Sound data

RE: #1 I was really surprised to see the core integration not supporting any power management.
RE: #2 I use this all of the time. I set the "hours" and clean the filter according to it.
RE: #3 My unit isn't in a bedroom, but I can see it being useful to turn the light off.
RE: #4 Again, my unit isn't in a bedroom, but that "beep" would be a pain if it were.

I don't expect anyone to make this right for me. I'm writing hoping that folks that update/maintain the core integration read this and think it might be something that is worth some time (instead of the timer on a new Samsung slow cooker :)

I can't thank everyone enough for their time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants