-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings after upgrade to HA 2025.1.0 #96
Comments
same issue but no emergency before 2025.1, just that it pollutes the logs |
I think i see the warnings:
|
I'm a newbie, but the README says, "This current integration is not maintainable..." and then goes on to say, "I have no need for this..." and, "I would be asking money for it..." Am I missing something? |
Hi, There are a lot of devices that are not supported by this integration. It is too much work to add support for every device individually and make sure it does not break others. Also keeping up with the official integration. This integration has everything I need for my personal devices. To be able to maintain other devices I would need to make a better integration for this purpose. I will fix these issues when they break the integration for me untill I get the new integration up and running. |
What would it take to maintain it?
…On Fri, Mar 15, 2024 at 8:50 PM Taneli Veistinen ***@***.***> wrote:
Hi,
There are a lot of devices that are not supported by this integration. It
is too much work to add support for every device individually and make sure
it does not break others. Also keeping up with the official integration.
This integration has everything I need for my personal devices. To be able
to maintain other devices I would need to make a better integration for
this purpose.
I will fix these issues when they break the integration for me untill I
get the new integration up and running.
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH52MNPKPQL7K5MCDOZRDLYYO6PRAVCNFSM6AAAAABBMPAXVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBRGQ4TKMRYG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Thanks, James
|
I hope that does mean that also in the future an integration will be there to manage the windfree airco's? Otherwise I have to try something else. |
I've fixed this to the point where there are no more deprecation warnings, but before releasing another fork that will probably not get merged, I'm wondering if someone could verify that the functionality that makes them want to use this integration is still not present in the official core integration. It looks like that one is being updated now. |
@cgraf Icemaker switch I can't solve that with other integrations either. |
Yeah, I don't think the fixing the future deprecation warnings is going to fix you ice maker and temps, but I will try to get it up in the next couple of days, just to remove some log pollution. I'm surprised your sensors previously worked, and no longer work, without error. A while back I added support for my own refrigerator, but that was as simple as including a model number somewhere I think. It is definitely difficult to maintain something like this, which supports a whole bunch of devices that a single author is not going to have. These aren't just $10 devices that you can buy for testing and be able to use. It really needs a maintainer for each device, or at least every major type of device, or it would be great if Samsung produced an emulator which mimics the signals from the devices. @niekniek89 what is the model number of your refrigerator? Not sure if you've checked them out but there are a couple of old PRs waiting for merge that add specific model support. https://github.com/veista/smartthings/pulls |
Just pushed the log cruft cleanup to my old existing branch. |
Thanks for your help so far. TP1X_REF_21K Samsung website (link) |
Ha! If that is actually your model, that is my model too, so I might be able to actually help you, however, the Samsung link you gave does not look like my model. I don't know much about SmartThings or Samsung model naming at all. It could be that TP1X_REF_21K is just a group of feature sets, rather than specific model. Grab the files from 1ac2c32 and overwrite the ones in your conf/custom_components/smartthings/ directory. Then restart home assistant (not quick restart). At the very least, your deprecation warnings go away, and at best maybe it fixes your actual issues. It shouldn't break anything or make anything worse for you. When this version is officially updated, it will overwrite these custom files automatically. You can also force an overwrite of my changes by going to HACS->Integrations->SmartThingsCustom->(click three dots in upper right and select "redownload"). |
If you have a look at the issue from nearly a year ago, you can see what my changes do for TP1X_REF_21K. I updated that branch today with the fixes for the deprecation warnings, so it has both sets of changes. |
Thanks for you’re help for now. |
@cgraf I just downloaded all 18 separate files, and placed them in conf/custom_components/smartthings/ After rebooting HA, I indeed no longer get any error messages! So I put the 18 separate files back. |
Heh. I actually had to look in my manual to see if I have those features. I apparently do, so I added support to TP1X_REF_21K. Grab the branch again and you should see them now. |
Thanks @cgraf the files were last modified 20 hours ago. |
The only file that changed this time was switch.py. If you still have your previous download, just grab switch.py. https://github.com/veista/smartthings/pull/83/files Incidentally I did test the enablement of power freeze, power cool and ice maker using the SmartThings iPhone app. My fridge has two ice types (cubes and bites). The switch only controls cubes. I may see at some point if I can add the switches for ice bites, and for water pitcher fill features, which are present in my fridge. |
Maybe I don't know what you are talking about. The "Power Cool" and "Power Freeze" switches may not have been present before? Not sure why icemaker is not showing. It is all in the same logic. |
hi, The "Power Cool" and "Power Freeze" switches were always visible. the temp sensors have also not been working for a long time, same as the icemaker switch. |
strange that it doesn't work for me yet... |
Ok. Maybe I misunderstood you comments
Are you sure you don't have anything under "entities not shown"? |
FWIW, before doing a lot of work on this custom branch of a customization of a core app, I decided to try the core app again since I see it is being updated. The functionality of the core app for my refrigerator is exactly the same as my branch here and the cooler setpoint slider actually works. The freezer slider still does not, but it has ice maker, power freeze and power cool switches which all work. I may just stick with that one for a while rather than doing a lot of work here. |
Smartthings api provides most functionality if implemented. Seems like now it is to the "official" integration, which is great. There are only minor things that are only in OCF, like climate display on/off functions. My idea is to make an itegration that provides "only" these missing functions and would be used with the "official" core integration. There is no point adding basic functions here, since after the transition this integration will be discarded. |
Thanks. I just removed the HACS integration "Smartthings", restarted HA, installed HACS, restarted HA and reconfigured it (with the modified files), but unfortunately not all sensors are seen (which has always worked before). Anyone? |
If you've installed the core version, you might try creating an issue there. There is no officially assigned maintainer, but it does look like it has an active community who may be able to help. |
I installed the smartthings integration within HACS, and not the default HA integration. |
You have three choices:
I'm on option 3 right now, and it is better than my fork. |
I have one Samsung/Smarthings device; a heat pump. I recently "changed" to the the core integration and changed back because I lost (or couldn't find).
RE: #1 I was really surprised to see the core integration not supporting any power management. I don't expect anyone to make this right for me. I'm writing hoping that folks that update/maintain the core integration read this and think it might be something that is worth some time (instead of the timer on a new Samsung slow cooker :) I can't thank everyone enough for their time. |
After upgrading to the latest HA Release, i see a lot of warnings:
The text was updated successfully, but these errors were encountered: