Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed translation to query string for get request #4

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fixed translation to query string for get request #4

merged 1 commit into from
Oct 15, 2020

Conversation

smskin
Copy link
Contributor

@smskin smskin commented Oct 15, 2020

Fixed translation associative array to query string for get requestUsing implode resulted in incorrect string generation from the array.
Get request with params:
'''
[
'by_user_id' => !$isSystem,
'props' => true,
'props_events' => false,
'props_custom' => false,
'presence_details' => true,
'events' => false,
'segments' => false,
'notes' => false
]
'''
translates to "https://api.carrotquest.io/v1/users/26?auth_token=[token]&1&1&&&1&&&".
You need to use http_build_query for translate associative array to query string

Fixed translation associative array to query string for get request
@veksa veksa merged commit ac73d2d into veksa:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants