More lint (#276)

* More lint

Signed-off-by: Steve Coffman <steve@khanacademy.org>

* Update versions

Signed-off-by: Steve Coffman <steve@khanacademy.org>

---------

Signed-off-by: Steve Coffman <steve@khanacademy.org>

.circleci/config.yml

@@ -2,13 +2,11 @@ version: 2
 jobs:
   build:
     docker:
-      - image: golang:1.16
+      - image: golang:1.19
     working_directory: /gqlparser
     steps:
       - checkout
-      - run: >
-          go get -u github.com/mattn/goveralls
       - run: go test -race ./...
       - run: go test -coverprofile=/tmp/coverage.out -coverpkg=./... ./...
-      - run: goveralls -coverprofile=/tmp/coverage.out -service=circle-ci -repotoken=$COVERALLS_TOKEN
-      - run: go test -count 25 ./... # check for flakey test ordering
+      - run: go run github.com/mattn/goveralls@latest -coverprofile=/tmp/coverage.out -service=circle-ci -repotoken=$COVERALLS_TOKEN
+      - run: go test -count 25 ./... # check for flaky test ordering

go.mod

@@ -1,6 +1,6 @@
 module github.com/vektah/gqlparser/v2
 
-go 1.18
+go 1.19
 
 require (
 	github.com/agnivade/levenshtein v1.1.1

parser/query.go

@@ -120,7 +120,7 @@ func (p *parser) parseOptionalSelectionSet() SelectionSet {
 		selections = append(selections, p.parseSelection())
 	})
 
-	return SelectionSet(selections)
+	return selections
 }
 
 func (p *parser) parseRequiredSelectionSet() SelectionSet {
@@ -134,7 +134,7 @@ func (p *parser) parseRequiredSelectionSet() SelectionSet {
 		selections = append(selections, p.parseSelection())
 	})
 
-	return SelectionSet(selections)
+	return selections
 }
 
 func (p *parser) parseSelection() Selection {

validator/walk.go

@@ -277,7 +277,7 @@ func (w *Walker) walkSelection(parentDef *ast.Definition, it ast.Selection) {
 		w.walkDirectives(nextParentDef, it.Directives, ast.LocationFragmentSpread)
 
 		if def != nil && !w.validatedFragmentSpreads[def.Name] {
-			// prevent inifinite recursion
+			// prevent infinite recursion
 			w.validatedFragmentSpreads[def.Name] = true
 			w.walkSelectionSet(nextParentDef, def.SelectionSet)
 		}