Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop validator mutating the provided *Schema #158

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Stop validator mutating the provided *Schema #158

merged 1 commit into from
Sep 7, 2021

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented May 27, 2021

The VariablesInAllowedPosition rule mutates the provided *ast.Value
which causes future validation to fails as well as altering the result
of the introspect query in gqlgen.

@xzyfer
Stop validator mutating the provided *Schema
2bc0a95 
The `VariablesInAllowedPosition` rule mutates the provided *ast.Value
which causes future validation to fails as well as altering the result
of the introspect query in gqlgen.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 92.155% when pulling 2bc0a95 on xzyfer:fix-schema-mutation into 5a9c950 on vektah:master.

@xzyfer
Copy link
Contributor Author

xzyfer commented Aug 2, 2021

🙏

@aurelijusbanelis aurelijusbanelis mentioned this pull request Aug 26, 2021
Merged
@lwc lwc merged commit 2a3d320 into vektah:master Sep 7, 2021
@StevenACoffman StevenACoffman mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xzyfer @coveralls @lwc