Allow doubly-defined builtin directives #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we don't want to let you define a directive twice.* But if the
directive is builtin, and one copy of it is from your schema while the
other is from the prelude, then we have to, because the spec only says
that such directives "may" be excluded from SDL. (This happens in
practice when you generate a schema from introspection, which does
define all builtins, and your generator doesn't filter them out.) So now
we allow it, only for builtin directives.
*Fun fact: technically the spec doesn't say we shouldn't. But I think
that's an error in the spec, and it's reasonable and correct to check.
In general I think the schema validation portions of the spec are
pretty incomplete :| .
Fixes #223