Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice for old config style #668

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

LandonTClipp
Copy link
Collaborator

This fixes #646. The old config style is being officially deprecated in favor of packages. Add documentation that explains this.

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage: 100.00000% and project coverage change: -1.27061 ⚠️

Comparison is base (7a91185) 76.54039% compared to head (0040d3d) 75.26978%.

❗ Current head 0040d3d differs from pull request most recent head a43101b. Consider uploading reports for the commit a43101b to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #668         +/-   ##
===================================================
- Coverage   76.54039%   75.26978%   -1.27062%     
===================================================
  Files              8           9          +1     
  Lines           2191        2224         +33     
===================================================
- Hits            1677        1674          -3     
- Misses           378         412         +34     
- Partials         136         138          +2     
Impacted Files Coverage Δ
cmd/mockery.go 58.95062% <100.00000%> (-3.21154%) ⬇️
pkg/config/config.go 70.56452% <100.00000%> (ø)
pkg/logging/logging.go 30.95238% <100.00000%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This fixes vektra#646. The old config style is being officially deprecated in favor of `packages`. Add documentation that explains this.
@LandonTClipp LandonTClipp merged commit 7696d20 into vektra:master Jul 9, 2023
@LandonTClipp LandonTClipp deleted the deprecation branch July 9, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate legacy config semantics once packages is in full release
1 participant