Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Combine wrappers for commonly used one-shot SendBird functions. #1

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Add Combine wrappers for commonly used one-shot SendBird functions. #1

merged 3 commits into from
Apr 27, 2020

Conversation

drrajan
Copy link
Member

@drrajan drrajan commented Apr 22, 2020

No description provided.

zac
zac reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@zac zac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Just a couple comments.

SendBirdCombine/Classes/SBDMain+Combine.swift Outdated Show resolved Hide resolved
SendBirdCombine/Classes/SBDMain+Combine.swift Show resolved Hide resolved
SendBirdCombine/Classes/SBDMain+Combine.swift Outdated Show resolved Hide resolved
@drrajan drrajan merged commit fb089cb into master Apr 27, 2020
@drrajan drrajan deleted the feature/initial-oneshot-wrappers branch April 27, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zac zac zac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drrajan @zac