fix(pipe.parser): RangeError: Maximum call stack size exceeded
on nested templates
#34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so much for maintaining this project!
With #27 we get the exception
RangeError: Maximum call stack size exceeded
on some templates. ThefindPipesInNode => extractPipesFromChildNodes => findPipesInNode
recursion on a class fails on depth 18, e.g. this template:Which apparently can happen if you dabble with some nested diffs, forms, bootstrap boilerplate, angular blocks and some ternary to finish it off.
This PR cleans up the recursion via two traversal methods that don't hold much context, allowing to traverse through nested templates (from before depth 18 to ~700 in this PR).