Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move typescript to dev dependencies #2816

Merged

Conversation

coopbri
Copy link
Contributor

@coopbri coopbri commented Apr 27, 2024

Description

During the bootstrapping process of @vendure/create, the typescript package is installed as a regular dependency, I moved it to the dev dependencies.

Regarding dotenv, it appears it's only used in the CLI, dev server, and in E2E tests for the payments plugin, please let me know if I missed something and it should be kept as a prod dep.

Breaking changes

No

Screenshots

N/A

Checklist

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for effervescent-donut-4977b2 ready!

Name Link
🔨 Latest commit aebde9e
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/663b1b21e4e91c00087f0540
😎 Deploy Preview https://deploy-preview-2816--effervescent-donut-4977b2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michaelbromley
Copy link
Member

Hi,

The reason that dotenv is a regular dependency is that in the vendure-config.ts file, it is used to automatically load env vars which are used in the config. Moving it to a dev dependency would require a change to how env vars are handled there.

I think moving typescript to a devDependency is fine though. I can't off the top of my head think of why that would be an issue.

@coopbri coopbri changed the title Move dotenv and typescript to dev dependencies Move typescript to dev dependencies May 8, 2024
@coopbri
Copy link
Contributor Author

coopbri commented May 8, 2024

Hi,

The reason that dotenv is a regular dependency is that in the vendure-config.ts file, it is used to automatically load env vars which are used in the config. Moving it to a dev dependency would require a change to how env vars are handled there.

I think moving typescript to a devDependency is fine though. I can't off the top of my head think of why that would be an issue.

Revised!

@michaelbromley michaelbromley merged commit b3c29e7 into vendure-ecommerce:master May 31, 2024
16 checks passed
@michaelbromley
Copy link
Member

Thank you!

@coopbri coopbri deleted the chore/create-dev-deps branch May 31, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants