Provide a basic implementation of the AR4SI token #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1 Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
setrofim
requested changes
Sep 28, 2022
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
| // Copyright 2022 Contributors to the Veraison project. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package ar4si |
There was a problem hiding this comment.
Ideally I would prefer the name "attestationResults" both for the package name and also github name.
Yes, one may argue that this name is aligned with what they use in standards body but strictly speaking it is not a very intuitive name and also 4 does not really map to for
yogeshbdeshpande
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1