Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document sign as experimental #55

Closed
2 tasks done
SteveLasker opened this issue Apr 22, 2022 · 0 comments · Fixed by #58
Closed
2 tasks done

Document sign as experimental #55

SteveLasker opened this issue Apr 22, 2022 · 0 comments · Fixed by #58
Assignees
@yogeshbdeshpande
Milestone
v1-alpha.1

Comments

@SteveLasker
Copy link
Contributor

SteveLasker commented Apr 22, 2022 •
edited by thomas-fossati
Loading

v0.1.0.alpha.1 will focus on sign1 code paths. The sign codepaths still exists, but we need to set proper expectations that these paths are not complete, nor reviewed for same level of security reviews as sign1.
Code should be documented as such, possibly emitting output to the consumer.

  • Add readme.md content, indicating sign is experimental
  • Add code comments, indicating sign is experimental, including godoc
@SteveLasker SteveLasker added this to the v1-alpha.1 milestone Apr 22, 2022
@thomas-fossati thomas-fossati mentioned this issue Apr 22, 2022
Merged
thomas-fossati added a commit that referenced this issue Apr 22, 2022
@thomas-fossati
mark COSE_Sign public interfaces as experimental
fd82999 
Fix #55

Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yogeshbdeshpande yogeshbdeshpande

Labels
None yet
Projects
None yet
Milestone
v1-alpha.1
Development

Successfully merging a pull request may close this issue.

Mark COSE Sign as experimental veraison/go-cose
2 participants
@SteveLasker @yogeshbdeshpande