Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct return error code when key cannot be decoded #130

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

yogeshbdeshpande
Copy link
Contributor

Signed-off-by: Yogesh Deshpande yogesh.deshpande@arm.com

@yogeshbdeshpande yogeshbdeshpande marked this pull request as ready for review February 10, 2023 14:17
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #130 (204bb9e) into main (07c7d28) will increase coverage by 0.30%.
The diff coverage is 100.00%.

❗ Current head 204bb9e differs from pull request most recent head eba8d14. Consider uploading reports for the commit eba8d14 to get more accurate results

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   91.82%   92.12%   +0.30%     
==========================================
  Files          10       10              
  Lines         978      978              
==========================================
+ Hits          898      901       +3     
+ Misses         54       51       -3     
  Partials       26       26              
Impacted Files Coverage Δ
signer.go 100.00% <100.00%> (ø)
verifier.go 100.00% <100.00%> (ø)
headers.go 93.05% <0.00%> (+0.90%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fixes #124
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
@yogeshbdeshpande yogeshbdeshpande merged commit 0cd299d into main Feb 10, 2023
@yogeshbdeshpande yogeshbdeshpande deleted the issue-214-branch branch February 10, 2023 17:51
SteveLasker added a commit to SteveLasker/go-cose that referenced this pull request Feb 15, 2023
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

markdown format

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

PR Feedback

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

Remove zombied code of conduct

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

PR Feedback

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

Merge conflicts

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

Update references to v1.0.0 (veraison#129)

Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>

Update Code of Conduct (veraison#128)

Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>

Correct return error code when key cannot be decoded (veraison#130)
SteveLasker added a commit to SteveLasker/go-cose that referenced this pull request Feb 15, 2023
author Steve Lasker <stevenlasker@hotmail.com> 1674848151 -0800
committer Steve Lasker <stevenlasker@hotmail.com> 1676501778 -0800
gpgsig -----BEGIN PGP SIGNATURE-----

 iQJNBAABCgA3FiEEhq1fE1ajEbAM5+4Y+K0yn4Ipqz4FAmPtYxIZHHN0ZXZlbmxh
 c2tlckBob3RtYWlsLmNvbQAKCRD4rTKfgimrPiFGEACyEqM5Z1HTcwjDce9iHE8e
 l85yMpIebd2KlWpAYClMTw3pneZZ8KbLsd8E8IfAGd28tDhKRmdpzDlTjh0gwpdq
 Nv0omy8VfP/uhGlNKe3SnPdZQU4nz5zjRXXJsGSD7CRfsfPN7b/EmanD1G/k8wzB
 bNoomTehpkqZbILPa4yrmfc7pyBc/EwTkyzPwXhGEyyciqJvtPjRN/fxYsUZSrYr
 WqWLhSJkdn9S3IB84ryqbwBBsU0u2ZcFp1wt4ysukSi13WvXwIxZxMqIRmF21Wxj
 TnU5KJ5AvAU72k1PZr1O1B4O6Ahfo/UTTyoRaIvMRRuQ5EdcjAqNb4fk+zIES6FZ
 zUxZdMdUMCI1QK/0JzHggS1C7W5eSd5cnfq7nrJ4JwATiF2zyxM5n8cnInY4BYhC
 YrIVFDECtuz85AFgOc/zDaPVpbZO5Crw0oX6BMp8qFklg0zmaKr3dwzyPlrMvyMY
 REJb33lcjcG71+vNn7jnmF1Lf8IKzHiI4FhQkETVwjBNh3o8J9msbV9E/tAINoew
 D4GHLEIqff5JGWxaGaDU4uG7+HS+JDV0V21pW04fXfQYw7+5tbJBYtT0VZ58mnCd
 7vlrhDpISjyTRVpRbyHhOGbz6lzSvtLsEUEQu5gBrSRJ2bJaHfD/2VXeOOPfLRyF
 +AMCRKGexVDrghurbyD9oA==
 =cbrx
 -----END PGP SIGNATURE-----

parent 4dbb9a7
author Steve Lasker <stevenlasker@hotmail.com> 1674848151 -0800
committer Steve Lasker <stevenlasker@hotmail.com> 1676501439 -0800
gpgsig -----BEGIN PGP SIGNATURE-----

 iQJNBAABCgA3FiEEhq1fE1ajEbAM5+4Y+K0yn4Ipqz4FAmPtYb8ZHHN0ZXZlbmxh
 c2tlckBob3RtYWlsLmNvbQAKCRD4rTKfgimrPiT5D/9THqSLPbaKQPBxxGAF3WCk
 SJRKhU5c0c/bZiloCbRqSRE6Dg0BDO8tk2qqHjxoo8I4k916MVycGghdku+hW0XD
 QepeXJLe1++DXrWOXaqVgPquoiSm8RxisQ1k6AATsXzTtg5JtaXUQzbGN/kS6WY/
 srBjq9XeXwIE5aVU7VVfkkLjj/R6XcuKf34HNKEY98E4VUC8iWzX/x76jSxSkG1x
 PUpYKM9PEIqzdad3aA5+S17iGKEE5IfNJBOljXex7w6HXVpfJUumr3T4300dTpVV
 kuAYGoPMhNPHBjrX+YyHxpXJENZXmlov6A4j6dmTdNs1C/WGRpbz2SQS7/kKtJEp
 QeMsHlVgFmeOvY2Cfoowbw9sVOGtO/rbZvwgBh6jkcfeeqBOEy99ZvjuFomfa9xk
 L2wWFg2V8StvlzgJgAoly3Ya2ui0Be8GyCU2QKKpREn+++bqS7fAPZIin/xck8K+
 QpQBdrogX4T2Fn+PGMuqiWf0nUE3RXaC+v3eCQWrigC0k0SuE/P+Sg08myPAgCgZ
 uZBClB1hk5JUegEOTqvSRwfqUjMSEGCKVFNk4leNdDdpc8STRT5kN8lr50hFvDAr
 4a6y0NngUqJuBTvejmqc1mYBzpLBbFhXROJjCfrawGmPkehbxYbALDQtX6bV3x1P
 qFc9qc4SrSRG1nKRF1YPjQ==
 =49O0
 -----END PGP SIGNATURE-----

Add community and governance content

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

markdown format

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

PR Feedback

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

Remove zombied code of conduct

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

PR Feedback

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

Merge conflicts

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

Update references to v1.0.0 (veraison#129)

Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>

Update Code of Conduct (veraison#128)

Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>

Correct return error code when key cannot be decoded (veraison#130)

Check EC point is on curve at Verifier instantiation (veraison#116)

Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>

Remove zombied code of conduct

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

PR Feedback

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

Merge conflicts

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>

Update references to v1.0.0 (veraison#129)

Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com>

Correct return error code when key cannot be decoded (veraison#130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants