Add beforeRegisterShippingMethods event for modying the master list of shipping methods before handing off to Commerce.
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he master list of shipping methods before they get handed off to Commerce.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #67...
The
modifyShippingMethodsevent currently implemented in eachProvideronly allows modification of the individual provider's potential methods, before the methods are hydrated with price info from the Rates.We need a way to modify the final collection of shipping methods from Postie, before they get registered with Commerce, but after they have prices assigned.
This way, we can make modifications that are conditional upon comparisons between all the available shipping rates.
Pretty please... 🙏🏼