Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fall back to headers#get when headers#getAll unavailable #213

Closed

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Nov 11, 2022

Related: vercel/next.js#42374 when released, this should be included in vercel/next.js#42736 also

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2022

🦋 Changeset detected

Latest commit: c602e9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@edge-runtime/cookies Patch
edge-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
edge-runtime ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 1:59PM (UTC)

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Merging #213 (c602e9a) into main (f9ef953) will increase coverage by 2.89%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   84.55%   87.44%   +2.89%     
==========================================
  Files          24       24              
  Lines        1994     1999       +5     
  Branches      177      176       -1     
==========================================
+ Hits         1686     1748      +62     
+ Misses        286      244      -42     
+ Partials       22        7      -15     
Impacted Files Coverage Δ
packages/runtime/src/server/create-handler.ts 79.71% <0.00%> (-1.18%) ⬇️
packages/cookies/src/response-cookies.ts 86.91% <100.00%> (+6.14%) ⬆️
packages/jest-environment/src/index.ts 100.00% <0.00%> (+2.04%) ⬆️
packages/vm/src/vm.ts 97.93% <0.00%> (+2.06%) ⬆️
packages/vm/src/edge-vm.ts 100.00% <0.00%> (+5.37%) ⬆️
packages/vm/src/require.ts 85.86% <0.00%> (+5.43%) ⬆️
packages/vm/src/temp-file.ts 100.00% <0.00%> (+5.55%) ⬆️
packages/cookies/src/serialize.ts 85.89% <0.00%> (+29.48%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@balazsorban44 balazsorban44 marked this pull request as draft November 14, 2022 09:51
@balazsorban44
Copy link
Member Author

Closing in favor of #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants