Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set and clear notifications for resources #25

Merged

Conversation

adriancooney
Copy link
Collaborator

Screenshot 2024-05-29 at 16 17 30

@adriancooney adriancooney requested review from lukahartwig and correttojs and removed request for lukahartwig May 29, 2024 15:17
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
example-marketplace-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 3:18pm
example-marketplace-integration-stable ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 3:18pm

@@ -50,3 +56,54 @@ export async function rotateCredentialsAction(
},
]);
}

export async function clearResourceNotificationAction(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to make the notification auto-expiring...but this works as well!

Copy link
Collaborator

@correttojs correttojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great feature, thanks for adding it!

@adriancooney adriancooney merged commit 4380868 into main May 29, 2024
3 checks passed
@adriancooney adriancooney deleted the adriancooney/marketplace/add-notification-example branch May 29, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants