-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version lock werkzeug #926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
requested review from
okbel,
lfades,
goncy,
dominiksipowicz,
leerob and
lpalmes
as code owners
June 17, 2024 18:16
trek
approved these changes
Jun 17, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leerob
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
leerob
pushed a commit
that referenced
this pull request
Jun 17, 2024
Updates our NextJS/Flask example to Flask 3, which also solves the issue fixed in #926 but in a way that gets Flask on latest. This also incorporate the change in #922 (Thanks @0xWerz ) and closes #816 #831 #906 #816. For the Flask2 specific example pins `werkzeug` to avoid transient dependency errors where it pulls in the incompatible `werkzeug@3.x` * Next/Flask deploy: https://nextjs-flask-guc4p7qgk-trek-glowacki.vercel.app/ * Flask 3 deploy: https://flask3-b6hmmqcnd-trek-glowacki.vercel.app/ * Flask 2 deploy: https://flask2-97jddsq6c-trek-glowacki.vercel.app/ --------- Co-authored-by: Musa <78509039+0xWerz@users.noreply.github.com>
newcharmingdev7
pushed a commit
to newcharmingdev7/e-com
that referenced
this pull request
Aug 10, 2024
Updates our NextJS/Flask example to Flask 3, which also solves the issue fixed in vercel/examples#926 but in a way that gets Flask on latest. This also incorporate the change in vercel/examples#922 (Thanks @0xWerz ) and closes #816 #831 #906 #816. For the Flask2 specific example pins `werkzeug` to avoid transient dependency errors where it pulls in the incompatible `werkzeug@3.x` * Next/Flask deploy: https://nextjs-flask-guc4p7qgk-trek-glowacki.vercel.app/ * Flask 3 deploy: https://flask3-b6hmmqcnd-trek-glowacki.vercel.app/ * Flask 2 deploy: https://flask2-97jddsq6c-trek-glowacki.vercel.app/ --------- Co-authored-by: Musa <78509039+0xWerz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Demo URL
Type of Change
New Example Checklist
npm run new-example
was used to create the example