Render overview on the index route #35
Conversation
|
Amazing! Looks great. Could you please make the function for rendering the handlebars template asynchronous? In addition, I don't see a need for including |
lib/view.js
Outdated
| let viewContent = false | ||
| const viewPath = path.normalize(path.join(__dirname, '/../views/index.hbs')) | ||
|
|
||
| try { | ||
| viewContent = fs.readFileSync(viewPath, 'utf8') | ||
| viewContent = await readFileAsync(viewPath, { encoding: 'utf8' }) |
There was a problem hiding this comment.
'utf8' works even with the native module 😊 no need for an object
lib/view.js
Outdated
| try { | ||
| viewContent = await readFileAsync(viewPath, 'utf8') | ||
| } catch (err) { | ||
| throw err |
There was a problem hiding this comment.
If you don't handle the error, you can just write:
const viewContent = await readFileAsync(viewPath, 'utf8')Without the try/catch block 😊
There was a problem hiding this comment.
This also means you can remove the let viewContent = false at the top... 🚀
lib/routes.js
Outdated
| const details = { | ||
| account: config.account, | ||
| repository: config.repository, | ||
| date: timeago().format(cache.latest.pub_date), |
There was a problem hiding this comment.
Let's use date-fns here please 😊 It's faster, slimmer and currently the best option out there.
views/index.hbs
Outdated
| background: linear-gradient(#ff00a5, #f65538) | ||
| } | ||
|
|
||
| #releaseNotes { |
There was a problem hiding this comment.
No camelcase in CSS properties please, always dashes (also adjust the HTML) 😊
leo
changed the title
|
Thank you for this wonderful PR! 😊 |
|
No worries. Learnt about date-fns. Looks really good! 👍 |
Solves #13
Renders an overview page using handlebars.
Had to add the size of the files in the cache to be able to display them.
Added a few packages: