Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Permit options be passed to hyper/electron bin #2839

Open
chabou opened this issue Apr 16, 2018 · 2 comments
Open

CLI: Permit options be passed to hyper/electron bin #2839

chabou opened this issue Apr 16, 2018 · 2 comments
Labels
⌨️ CLI tool Issue or PR related to CLI tool help wanted Contributions wanted towards the issue

Comments

@chabou
Copy link
Contributor

chabou commented Apr 16, 2018

We need to permit users to pass options directly to hyper/Electron bin.

For example: hyper --ignore-gpu-blacklist

@chabou chabou added help wanted Contributions wanted towards the issue ⌨️ CLI tool Issue or PR related to CLI tool labels Apr 16, 2018
@CrazyByDefault
Copy link

Hyper currently uses args to handle command-line arguments at runtime, but as far as I could tell, args has no way of handling unknown options. We'll either need to include all of the options that can be passed to Electron manually, or use a different implementation for handling CLI arguments.

In particular, yargs seems to have a way of routing the arguments through custom middleware before running the command associated with them.

@chabou
Copy link
Contributor Author

chabou commented Apr 17, 2018

Totally opened to replace args by something else :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ CLI tool Issue or PR related to CLI tool help wanted Contributions wanted towards the issue
Projects
None yet
Development

No branches or pull requests

2 participants