Prevent loosing focus after a char composition ended by Tab key. Fix #1341 #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really appreciate your time debugging this @chabou |
tylerong
pushed a commit
to tylerong/hyper
that referenced
this pull request
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a char composition ends with a Tab key, after a first
onKeyDown_(e)call, another one occurs with a different keycode (192) but the same timestamp and same key (Tab).This second
onKeyDown_event cause a blur and Term loose its focus.Notice: A breakpoint in
onTextInput_prevent this second event. Race condition ?