Add onDecorated property to decorated components #1680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins could be more powerful if we give them a way to retrieve a reference to decorated components.
The only reference that a plugin could have is
hterm
by passing aonTerminal
property.It could use
ref
property in decorators but if it is not the first in plugin list, it will receive previous plugin HOC.With this PR, every plugin's
decorate<Component>
functions (decorateTerm, decorateTerms, decorateHeader, decorateTab...) could retrieve a reference to instance.Maybe it is a little dangerous/anti-pattern to expose all instances to plugins, but this is the same logic than
onTerminal
property.If you are ok with this feature, I'll add website documentation.