check for null/undefined session in addSessionData #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppot
reviewed
Mar 25, 2017
lib/actions/sessions.js
Outdated
| data | ||
| }); | ||
| const session = getState().sessions.sessions[uid]; | ||
| if (session !== null && session !== undefined) { |
There was a problem hiding this comment.
if (session) should do the trick
ppot
added
the
👩🔬 Status: In Progress
|
friendly ping? :) This is hitting me almost every day |
2 tasks
timja
approved these changes
Apr 28, 2017
|
Great work btw, @zsol! |
| type: SESSION_PTY_DATA, | ||
| uid, | ||
| data | ||
| }); |
There was a problem hiding this comment.
Why has this been moved outside of the else? Will it happen twice if it is a URL?
|
No it won't, notice the return in the then double if. I think it's cleaner
this way.
…On Fri, Apr 28, 2017, 22:19 Marty Gentillon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/actions/sessions.js
<#1698 (comment)>:
> }
+ dispatch({
+ type: SESSION_PTY_DATA,
+ uid,
+ data
+ });
Why has this been moved outside of the else? Will it happen twice if it
isn't a URL?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1698 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEEtMEvixou2mlIl379cuvoQbqfjSWBks5r0lfGgaJpZM4MouOg>
.
|
ppot
approved these changes
Apr 29, 2017
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around incorrect event ordering between
SESSION_PTY_EXITandSESSION_ADD_DATA. See #1628 for more context.This is ready to merge. Fixes #1628.