Update window creation #2028
Merged
Update window creation #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinekb
reviewed
Aug 2, 2017
app/ui/window.js
Outdated
|
|
||
| module.exports = class Window extends BrowserWindow { | ||
| constructor(opts, cfg, fn) { | ||
| opts = Object.assign({ |
There was a problem hiding this comment.
This could be rewritten immutable (using const only)
albinekb
reviewed
Aug 2, 2017
app/ui/window.js
Outdated
| }); | ||
|
|
||
| rpc.on('new', opts => { | ||
| opts = Object.assign({ |
There was a problem hiding this comment.
same here (immutable, const)
albinekb
approved these changes
Aug 2, 2017
chabou
added a commit
to chabou/hyper
that referenced
this pull request
Sep 5, 2017
Regression introduced by vercel#2028
chabou
added a commit
to chabou/hyper
that referenced
this pull request
Sep 5, 2017
Regression introduced by vercel#2028
Merged
spncrgr
pushed a commit
to spncrgr/hyper
that referenced
this pull request
Sep 23, 2017
Regression introduced by vercel#2028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change