Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show update channel in About window #2102

Merged
merged 2 commits into from
Aug 20, 2017
Merged

Show update channel in About window #2102

merged 2 commits into from
Aug 20, 2017

Conversation

leo
Copy link
Contributor

@leo leo commented Aug 20, 2017

So that people know which channel they're on without opening the config file.

STABLE:

screen shot 2017-08-20 at 12 37 14

CANARY:

screen shot 2017-08-20 at 12 36 55

@leo leo added 🍎 Platform: Mac Issue pertains to Mac 🖼 Platform: Windows Issue pertains to Windows 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper labels Aug 20, 2017
@leo leo requested a review from chabou August 20, 2017 10:38
const keymaps = getKeymaps();

const updateChannel = config.canaryUpdates ? 'canary' : 'stable';
const commands = keymaps.commands;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe directly:
const {commands} = getKeymaps(); ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@leo leo merged commit fa1b607 into master Aug 20, 2017
@leo leo deleted the update-channel-about branch August 20, 2017 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 Platform: Mac Issue pertains to Mac 🖼 Platform: Windows Issue pertains to Windows 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants