Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore v1 keymaps for tab switching #2485

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Restore v1 keymaps for tab switching #2485

merged 2 commits into from
Nov 22, 2017

Conversation

chabou
Copy link
Collaborator

@chabou chabou commented Nov 22, 2017

albinekb
albinekb approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@albinekb albinekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! 🎉

albinekb
albinekb reviewed Nov 22, 2017
View reviewed changes
app/keymaps/linux.json Outdated
@@ -36,4 +46,4 @@
"editor:deleteEndLine": "ctrl+end",
"editor:clearBuffer": "ctrl+shift+k",
"plugins:update": "ctrl+shift+u"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

albinekb
albinekb reviewed Nov 22, 2017
View reviewed changes
app/keymaps/win32.json Outdated
@@ -36,4 +46,4 @@
"editor:deleteEndLine": "ctrl+end",
"editor:clearBuffer": "ctrl+shift+k",
"plugins:update": "ctrl+shift+u"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

albinekb
albinekb reviewed Nov 22, 2017
View reviewed changes
app/keymaps/darwin.json Outdated
@@ -37,4 +47,4 @@
"editor:clearBuffer": "command+k",
"editor:emojis": "command+ctrl+space",
"plugins:update": "command+shift+u"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

@chabou chabou merged commit a59ccc3 into vercel:canary Nov 22, 2017
@rauchg
Copy link
Member

rauchg commented Nov 22, 2017

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinekb albinekb albinekb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chabou @rauchg @albinekb