Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keymap to rebind the 'break' command - Issue #2432 #2531

Merged
merged 5 commits into from
Dec 18, 2017

Conversation

ineeve
Copy link
Contributor

@ineeve ineeve commented Dec 8, 2017

Created a keymap to rebind the break/interrupt command as asked here
I have only tested on Windows 10, but I think it should also work on Linux and MacOS.
Any feedback is appreciated.

@ineeve ineeve changed the title Added keymap to rebind the 'break' command - Issue 2432 Added keymap to rebind the 'break' command - Issue #2432 Dec 8, 2017
Copy link
Contributor

@albinekb albinekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albinekb
Copy link
Contributor

albinekb commented Dec 18, 2017

Doesn't this break ctrl+c for copy in windows and linux? @ineeve @chabou

In macOS ctrl+c is good for break, that's how it works in iTerm & Terminal.app since we have cmd+c for copy.

But for windows and linux I don't know, is this expected? How do you copy text when ctrl+c is bound to break?


This is already default, so let's keep it. Thanks for the PR!

@albinekb albinekb merged commit cb8b72a into vercel:canary Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants