Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use public API to remove xterm listeners #2543

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Use public API to remove xterm listeners #2543

merged 1 commit into from
Dec 16, 2017

Conversation

Tyriar
Copy link
Contributor

@Tyriar Tyriar commented Dec 11, 2017

This uses the public API to do the same thing. Note that I didn't verify this but I think it should work.

albinekb
albinekb approved these changes Dec 11, 2017
View reviewed changes
Copy link
Contributor

@albinekb albinekb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chabou did you test this? How can i verify if this works? 👍

@chabou chabou merged commit 7be41e1 into vercel:canary Dec 16, 2017
@chabou
Copy link
Collaborator

chabou commented Dec 16, 2017

Thank you so much for your help @Tyriar

@Tyriar Tyriar deleted the dont_use_private branch December 17, 2017 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chabou chabou chabou approved these changes

@albinekb albinekb albinekb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @chabou @albinekb