Fix xterm fork version #2618
Merged
Fix xterm fork version #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chabou
added
the
👩🔬 Status: In Progress
|
Short commit was a good idea BUT... I noticed that when you are using a github dependency, and you want to change pointing Branch/Commit/Tag, you MUST change version number of dependency in its package.json. Otherwise, previous fetched "package" can be use. I noticed this with Ready to merge |
chabou
removed
the
👩🔬 Status: In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using short commit sha was a bad idea. 😞