CLI: better existence check #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppot
reviewed
Feb 23, 2018
cli/api.js
Outdated
| .get(registryUrl + name.toLowerCase(), {timeout: 10000, json: true}) | ||
| .then(res => { | ||
| if (!res.body.versions) { | ||
| throw new Error(); |
There was a problem hiding this comment.
Error should be defined with a message.
There was a problem hiding this comment.
Meh, just used to get into the .catch block here. Could alternatively return Promise.reject();.
brandon93s
approved these changes
Feb 23, 2018
ppot
approved these changes
Feb 23, 2018
|
@brandon93s @ppot Thank you for your reviews. You were both right. I refactored it and looks a way better now. |
albinekb
approved these changes
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM registry is broken for some (unpublished?) package:
https://registry.npmjs.org/hyper-cwd
https://api.npms.io/v2/package/hyper-cwd (error 500)
Checking headers on npm is not enough.
Now,
versionskey existence is checked in content