WebGL renderer (using xterm.js fork) #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcchoi
added a commit
to wcchoi/swell.sh
that referenced
this pull request
May 10, 2019
Learning from Hyper's 3.0.0 release [1,2], this commit also switches to use WebGL2 renderer of xterm.js (it uses zeit's fork of Tyriar's fork of xterm.js obtained from [3]) This results in significant speedup in Chrome. Particularly, page load/changing font size used to take several seconds, now with the new renderer it feels almost instantaneous! The WebGL renderer is only enabled on browsers that support it, i.e. Chrome NOTE: changes in static/lib/xterm/ files in this commit are from building [3] [1]: https://github.com/zeit/hyper/releases/tag/3.0.0 [2]: vercel/hyper#3368 [3]: https://registry.npmjs.org/@zeit/xterm/-/xterm-3.12.0-1.tgz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables webGL rendering behind the
webGLRendererconfig flag. It uses our own fork of xterm.js which includes the webGL renderer by @Tyriar.Although this renderer has a few limitations we are enabling it by default on the canary channel because we believe that the perf benefits outweight these limitations for most users. Additionally, we want to gather as much data as possible from the canary channel.
Tests
Benchmarks
Coming up...