Fix webgl config #3407
Merged
Fix webgl config #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rauchg Do you want an automatic fallback to canvas if the user is using a non-opaque background color? With this PR, |
j-f1
reviewed
Jan 11, 2019
Co-Authored-By: juancampa <juancampa@gmail.com>
Stanzilla
approved these changes
Jan 21, 2019
The hardcoding to white was also removed in favor of a temporary hack in xterm.js that uses either white-over-black or black-overwhite to maximize contrast with the background color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
webGLRendererflag was in the wrong place inconfig-default.js. Not letting new users change the renderer.webGLRendererwas incorrect. Defaulting to the canvas renderer.