Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore termRef #3437

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Restore termRef #3437

merged 1 commit into from
Jan 24, 2019

Conversation

igorsdv
Copy link
Contributor

@igorsdv igorsdv commented Jan 24, 2019

Fixes breaking change introduced in #3409

@rauchg
Copy link
Member

rauchg commented Jan 24, 2019

Is it possible to add a test to prevent regressions like this one?

chabou
chabou suggested changes Jan 24, 2019
View reviewed changes
Copy link
Collaborator

@chabou chabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but your PR has too many commit/changes.
Only your last commit should appear (and GitHub warns about some conflicts due to this).

@igorsdv
Copy link
Contributor Author

igorsdv commented Jan 24, 2019

@chabou Not sure why that happened, should be fixed now.

@juancampa juancampa merged commit 0dc8fb9 into vercel:canary Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancampa juancampa juancampa approved these changes

@chabou chabou chabou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igorsdv @rauchg @juancampa @chabou